From: Stephan Mueller <smueller@chronox.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Eric Biggers <ebiggers3@gmail.com>,
linux-fscrypt@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Michael Halcrow <mhalcrow@google.com>,
Paul Crowley <paulcrowley@google.com>,
Martin Willi <martin@strongswan.org>,
David Gstir <david@sigma-star.at>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] fscrypt: add support for ChaCha20 contents encryption
Date: Fri, 08 Dec 2017 11:14:54 +0100 [thread overview]
Message-ID: <6974144.ZTrPlmK77A@tauon.chronox.de> (raw)
In-Reply-To: <CAKv+Gu-GfHpukc0WA6z13xAfdcmL9LQUmH41J4GsuMP+m4ge3g@mail.gmail.com>
Am Freitag, 8. Dezember 2017, 11:06:31 CET schrieb Ard Biesheuvel:
Hi Ard,
>
> Given how it is not uncommon for counters to be used as IV, this is a
> fundamental flaw that could rear its head in other places as well, so
> I propose we fix this one way (fix the current code) or the other
> (deprecate the current code and create a new chacha20-rfc7539
> blockcipher that uses a 96-bit IV and sets the counter to 0)
Instead of having a complete new implementation of the ChaCha20 cipher, what
about using a specific IV generator for which the kernel crypto API has
already support (see crypto/seqiv.c for example)?
I.e. we have the current ChaCha20 cipher, but use some "rfc7539iv(chacha20)"
cipher mode where that rfc7539iv is the mentioned IV generator that turns the
given IV (sector number?) into the proper IV for ChaCha20.
Ciao
Stephan
next prev parent reply other threads:[~2017-12-08 10:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 1:38 [PATCH] fscrypt: add support for ChaCha20 contents encryption Eric Biggers
2017-12-08 2:51 ` Jason A. Donenfeld
2017-12-08 7:20 ` Ard Biesheuvel
2017-12-08 21:42 ` Eric Biggers
2017-12-11 16:11 ` David Gstir
2017-12-08 9:11 ` Ard Biesheuvel
2017-12-08 9:11 ` Ard Biesheuvel
2017-12-08 10:06 ` Ard Biesheuvel
2017-12-08 10:14 ` Stephan Mueller [this message]
2017-12-08 10:27 ` Ard Biesheuvel
2017-12-09 0:48 ` Jeffrey Walton
2017-12-10 18:59 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6974144.ZTrPlmK77A@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=Jason@zx2c4.com \
--cc=ard.biesheuvel@linaro.org \
--cc=david@sigma-star.at \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin@strongswan.org \
--cc=mhalcrow@google.com \
--cc=paulcrowley@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).