* [PATCH v2] f2fs: fix double free of unicode map
@ 2020-11-12 9:14 Hyeongseok Kim
2020-11-12 9:25 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Hyeongseok Kim @ 2020-11-12 9:14 UTC (permalink / raw)
To: yuchao0, jaegeuk
Cc: linux-f2fs-devel, linux-fsdevel, hyeongseok.kim, Hyeongseok Kim
In case of retrying fill_super with skip_recovery,
s_encoding for casefold would not be loaded again even though it's
already been freed because it's not NULL.
Set NULL after free to prevent double freeing when unmount.
Fixes: eca4873ee1b6 ("f2fs: Use generic casefolding support")
Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
---
fs/f2fs/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 00eff2f51807..fef22e476c52 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3918,6 +3918,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
#ifdef CONFIG_UNICODE
utf8_unload(sb->s_encoding);
+ sb->s_encoding = NULL;
#endif
free_options:
#ifdef CONFIG_QUOTA
--
2.27.0.83.g0313f36
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] f2fs: fix double free of unicode map
2020-11-12 9:14 [PATCH v2] f2fs: fix double free of unicode map Hyeongseok Kim
@ 2020-11-12 9:25 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2020-11-12 9:25 UTC (permalink / raw)
To: Hyeongseok Kim, jaegeuk; +Cc: linux-f2fs-devel, linux-fsdevel, hyeongseok.kim
On 2020/11/12 17:14, Hyeongseok Kim wrote:
> In case of retrying fill_super with skip_recovery,
> s_encoding for casefold would not be loaded again even though it's
> already been freed because it's not NULL.
> Set NULL after free to prevent double freeing when unmount.
>
> Fixes: eca4873ee1b6 ("f2fs: Use generic casefolding support")
> Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 9:14 [PATCH v2] f2fs: fix double free of unicode map Hyeongseok Kim
2020-11-12 9:25 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).