From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5A1C2D0A3 for ; Thu, 12 Nov 2020 09:25:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9979822202 for ; Thu, 12 Nov 2020 09:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbgKLJZo (ORCPT ); Thu, 12 Nov 2020 04:25:44 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7212 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbgKLJZo (ORCPT ); Thu, 12 Nov 2020 04:25:44 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CWx5z41zSzkg2y; Thu, 12 Nov 2020 17:25:27 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 12 Nov 2020 17:25:34 +0800 Subject: Re: [PATCH v2] f2fs: fix double free of unicode map To: Hyeongseok Kim , CC: , , References: <20201112091454.15311-1-hyeongseok@gmail.com> From: Chao Yu Message-ID: <6a442a9c-d8ab-3e5f-fda8-fabbbca2ed32@huawei.com> Date: Thu, 12 Nov 2020 17:25:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201112091454.15311-1-hyeongseok@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2020/11/12 17:14, Hyeongseok Kim wrote: > In case of retrying fill_super with skip_recovery, > s_encoding for casefold would not be loaded again even though it's > already been freed because it's not NULL. > Set NULL after free to prevent double freeing when unmount. > > Fixes: eca4873ee1b6 ("f2fs: Use generic casefolding support") > Signed-off-by: Hyeongseok Kim Reviewed-by: Chao Yu Thanks,