linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: mtk.manpages@gmail.com, David Howells <dhowells@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	hch@infradead.org
Subject: Re: Unchecked flags in statx(2) [Should be fixed before 4.11-final?]
Date: Fri, 21 Apr 2017 21:19:31 +0200	[thread overview]
Message-ID: <6b5580c6-e163-0404-17e4-6c1c3777bc76@gmail.com> (raw)
In-Reply-To: <E9E3131F-5350-4828-8C22-0979273F94B4@dilger.ca>

Hello Andreas,

On 04/21/2017 08:16 PM, Andreas Dilger wrote:
> On Apr 21, 2017, at 7:13 AM, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
>>
>> On 04/21/2017 03:01 PM, David Howells wrote:
>>> Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
>>
>>> (3) There's no problem with asking for extra bits, even if the running
>>>     kerneldoes not support them, because the kernel tells you in its
>>>     response what fields it actually gave you.
>>
>> It's this piece that I overlooked. Makes sense, of course.
>> Sorry for the noise!
> 
> I agree with David that we don't want to return an error if the application
> asks for more bits than the kernel supports, otherwise the interface would
> be useless.

Yes, it's clear to me now.

> Maybe this implies that this needs to be explained more clearly in the
> statx man page?

Precisely; my thought also.

Cheers,

Michael 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

      reply	other threads:[~2017-04-21 19:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 12:14 Unchecked flags in statx(2) [Should be fixed before 4.11-final?] Michael Kerrisk (man-pages)
2017-04-21 12:28 ` Michael Kerrisk (man-pages)
2017-04-21 12:41 ` David Howells
2017-04-21 12:47 ` David Howells
2017-04-21 13:01 ` David Howells
2017-04-21 13:13   ` Michael Kerrisk (man-pages)
2017-04-21 18:16     ` Andreas Dilger
2017-04-21 19:19       ` Michael Kerrisk (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b5580c6-e163-0404-17e4-6c1c3777bc76@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=adilger@dilger.ca \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).