From: Chao Yu <chao@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] fsverity: stop using PG_error to track error status
Date: Fri, 25 Nov 2022 11:36:14 +0800 [thread overview]
Message-ID: <6bce9afb-2561-7937-caea-8aadaa5a21cd@kernel.org> (raw)
In-Reply-To: <20221028175807.55495-1-ebiggers@kernel.org>
On 2022/10/29 1:58, Eric Biggers wrote:
> @@ -116,43 +116,51 @@ struct bio_post_read_ctx {
> struct f2fs_sb_info *sbi;
> struct work_struct work;
> unsigned int enabled_steps;
> + bool decompression_attempted;
How about adding some comments for decompression_attempted? Otherwise it
looks good to me.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2022-11-25 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 17:58 [PATCH v3] fsverity: stop using PG_error to track error status Eric Biggers
2022-11-10 8:21 ` Eric Biggers
2022-11-23 22:19 ` Eric Biggers
2022-11-25 3:06 ` Chao Yu
2022-11-25 3:09 ` Eric Biggers
2022-11-25 3:36 ` Chao Yu [this message]
2022-11-25 19:22 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bce9afb-2561-7937-caea-8aadaa5a21cd@kernel.org \
--to=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).