From: Bernd Schubert <bernd.schubert@fastmail.fm>
To: Miklos Szeredi <miklos@szeredi.hu>,
Joanne Koong <joannelkoong@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, josef@toxicpanda.com,
kernel-team@meta.com
Subject: Re: [PATCH 2/2] fuse: update stats for pages in dropped aux writeback list
Date: Wed, 21 Aug 2024 20:26:35 +0200 [thread overview]
Message-ID: <6d1c802e-1635-414a-b0d7-ad5306bfaf8f@fastmail.fm> (raw)
In-Reply-To: <CAJfpegswvvE5oid-hPXsSXQpFezq3NLVdJWTr_eb4shFLJ2j4A@mail.gmail.com>
On 8/21/24 17:56, Miklos Szeredi wrote:
> On Mon, 19 Aug 2024 at 20:25, Joanne Koong <joannelkoong@gmail.com> wrote:
>>
>> In the case where the aux writeback list is dropped (eg the pages
>> have been truncated or the connection is broken), the stats for
>> its pages and backing device info need to be updated as well.
>
> Patch looks good. Thanks.
>
> Do you have a reproducer or was this found by code review only?
That's indeed a nice catch from Joanne!.
I would have expected that writing to a file and in parallel truncating
it would leak WritebackTmp in /proc/meminfo. But I see it going up and
always to 0 again.
Thanks,
Bernd
next prev parent reply other threads:[~2024-08-21 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 18:24 [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish Joanne Koong
2024-08-19 18:24 ` [PATCH 2/2] fuse: update stats for pages in dropped aux writeback list Joanne Koong
2024-08-20 2:10 ` Jingbo Xu
2024-08-20 18:21 ` Joanne Koong
2024-08-21 15:56 ` Miklos Szeredi
2024-08-21 18:26 ` Bernd Schubert [this message]
2024-08-21 20:22 ` Joanne Koong
2024-08-22 10:54 ` Miklos Szeredi
2024-08-20 1:53 ` [PATCH 1/2] fuse: drop unused fuse_mount arg in fuse_writepage_finish Jingbo Xu
2024-08-20 18:19 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1c802e-1635-414a-b0d7-ad5306bfaf8f@fastmail.fm \
--to=bernd.schubert@fastmail.fm \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).