From: Mike Kravetz <mike.kravetz@oracle.com>
To: yangerkun <yangerkun@huawei.com>, willy@infradead.org
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, yukuai3@huawei.com
Subject: Re: [PATCH v2] hugetlbfs: avoid overflow in hugetlbfs_fallocate
Date: Sat, 27 Nov 2021 09:50:14 -0800 [thread overview]
Message-ID: <6f9c9501-bf99-5eda-7486-5bf33ef627c2@oracle.com> (raw)
In-Reply-To: <20211124062452.2343575-1-yangerkun@huawei.com>
On 11/23/21 22:24, yangerkun wrote:
> luojiajun report a problem[1] two years ago which seems still exists in
> mainline. vfs_fallocate can avoid 'offset + len' trigger overflow, but
> 'offset + len + hpage_size - 1' may overflow too and will lead to a
> wrong 'end'. luojiajun give a solution which can fix the wrong 'end'
> but leave the overflow still happened. Fix it with DIV_ROUND_UP_ULL.
>
> [1] https://patchwork.kernel.org/project/linux-mm/patch/1554775226-67213-1-git-send-email-luojiajun3@huawei.com/
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
> ---
> fs/hugetlbfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you for fixing!
Matthew, thanks for DIV_ROUND_UP_ULL! I did not know that existed.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
prev parent reply other threads:[~2021-11-27 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 6:24 [PATCH v2] hugetlbfs: avoid overflow in hugetlbfs_fallocate yangerkun
2021-11-27 17:50 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f9c9501-bf99-5eda-7486-5bf33ef627c2@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yangerkun@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).