From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com ([119.145.14.66]:38164 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbdADDZg (ORCPT ); Tue, 3 Jan 2017 22:25:36 -0500 Subject: Re: [f2fs-dev] [PATCH 01/10] f2fs: reassign new segment for mode=lfs To: Jaegeuk Kim , , , References: <20161230185117.3832-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <702b01ba-5fcb-01a2-0bad-65ea9005b834@huawei.com> Date: Wed, 4 Jan 2017 11:24:36 +0800 MIME-Version: 1.0 In-Reply-To: <20161230185117.3832-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Jaegeuk, On 2016/12/31 2:51, Jaegeuk Kim wrote: > Otherwise we can remain wrong curseg->next_blkoff, resulting in fsck failure. Could you explain more about this case? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/segment.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index be9e4d244d75..4e5ffe1d97e4 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -1428,9 +1428,6 @@ void allocate_new_segments(struct f2fs_sb_info *sbi) > unsigned int old_segno; > int i; > > - if (test_opt(sbi, LFS)) > - return; > - > for (i = CURSEG_HOT_DATA; i <= CURSEG_COLD_DATA; i++) { > curseg = CURSEG_I(sbi, i); > old_segno = curseg->segno; >