linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: mtk.manpages@gmail.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
	linux-man@vger.kernel.org
Subject: Re: [PATCH] mount.2: note that mandatory locking is now fully deprecated
Date: Sat, 2 Oct 2021 19:39:54 +0200	[thread overview]
Message-ID: <70df73be-1f6a-2317-fe60-79c9d0575d5e@gmail.com> (raw)
In-Reply-To: <20211001115724.16392-1-jlayton@kernel.org>

Hello Jeff,

On 10/1/21 1:57 PM, Jeff Layton wrote:
> This support has been fully removed from the kernel as of v5.15.
> 
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>   man2/mount.2 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/mount.2 b/man2/mount.2
> index bedd39e68a68..a7ae65fb0142 100644
> --- a/man2/mount.2
> +++ b/man2/mount.2
> @@ -195,7 +195,8 @@ this mount option requires the
>   .B CAP_SYS_ADMIN
>   capability and a kernel configured with the
>   .B CONFIG_MANDATORY_FILE_LOCKING
> -option.
> +option. Mandatory locking has been fully deprecated in v5.15 kernels, so
> +this flag should be considered deprecated.

Please use semantic newlines, as man-pages(7) notes.  It is especially 
important here, as otherwise you're hardcoding the number of spaces 
after the '.' (which if you don't, will typically be 2).

See man-pages(7):

    Use semantic newlines
        In the source of a manual page,  new  sentences  should  be
        started  on  new  lines, and long sentences should be split
        into lines at clause breaks  (commas,  semicolons,  colons,
        and  so on).  This convention, sometimes known as "semantic
        newlines", makes it easier to see the  effect  of  patches,
        which often operate at the level of individual sentences or
        sentence clauses.


Cheers,

Alex

>   .TP
>   .B MS_NOATIME
>   Do not update access times for (all types of) files on this filesystem.
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

      reply	other threads:[~2021-10-02 17:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 11:57 [PATCH] mount.2: note that mandatory locking is now fully deprecated Jeff Layton
2021-10-02 17:39 ` Alejandro Colomar (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70df73be-1f6a-2317-fe60-79c9d0575d5e@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).