From: Xiubo Li <xiubli@redhat.com>
To: Jeff Layton <jlayton@kernel.org>, viro@zeniv.linux.org.uk
Cc: idryomov@gmail.com, vshankar@redhat.com,
ceph-devel@vger.kernel.org, arnd@arndb.de, mcgrof@kernel.org,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 2/2] ceph: wait the first reply of inflight unlink/rmdir
Date: Tue, 17 May 2022 19:59:34 +0800 [thread overview]
Message-ID: <718ffcfa-d211-23ec-947c-0c9dec33781c@redhat.com> (raw)
In-Reply-To: <bd2ea8d6467ff8ea98c7bd048fd417aced86e20d.camel@kernel.org>
On 5/17/22 7:54 PM, Jeff Layton wrote:
> On Tue, 2022-05-17 at 19:49 +0800, Xiubo Li wrote:
>> On 5/17/22 7:35 PM, Jeff Layton wrote:
>>> On Tue, 2022-05-17 at 09:03 +0800, Xiubo Li wrote:
>>>> In async unlink case the kclient won't wait for the first reply
>>>> from MDS and just drop all the links and unhash the dentry and then
>>>> succeeds immediately.
>>>>
>>>> For any new create/link/rename,etc requests followed by using the
>>>> same file names we must wait for the first reply of the inflight
...
>>> I doubt you need this large a hashtable, particularly given that this is
>>> per-superblock. In most cases, we'll just have a few of these in flight
>>> at a time.
>> A global hashtable ? And set the order to 8 ?
> Per-sb is fine, IMO. 6-8 bits sounds reasonable.
Sure, let's use 8. From my snaptest I can see there had a lot of
dentries in the hashtable at the same time some times.
-- Xiubo
prev parent reply other threads:[~2022-05-17 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 1:03 [PATCH v2 0/2] ceph: wait async unlink to finish Xiubo Li
2022-05-17 1:03 ` [PATCH v2 1/2] fs/dcache: add d_compare() helper support Xiubo Li
2022-05-17 1:03 ` [PATCH v2 2/2] ceph: wait the first reply of inflight unlink/rmdir Xiubo Li
2022-05-17 11:35 ` Jeff Layton
2022-05-17 11:49 ` Xiubo Li
2022-05-17 11:54 ` Jeff Layton
2022-05-17 11:59 ` Xiubo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=718ffcfa-d211-23ec-947c-0c9dec33781c@redhat.com \
--to=xiubli@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vshankar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).