From: hooanon05@yahoo.co.jp
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC Aufs2 #2 21/28] aufs sysfs entries
Date: Tue, 17 Mar 2009 12:26:42 +0900 [thread overview]
Message-ID: <7200.1237260402@jrobl> (raw)
In-Reply-To: <20090316180538.GA7069@kroah.com>
Thank you very much for reviewing.
Greg KH:
> > +/* todo: file size may exceed PAGE_SIZE */
> > +ssize_t sysaufs_si_show(struct kobject *kobj, struct attribute *attr,
> > + char *buf)
>
> NO IT CAN NOT!!!!
>
> You are using sysfs wrong if you even think you are getting close to
> PAGE_SIZE.
The main reason I left a comment about PAGE_SIZE is that some of aufs
entry under sysfs contain the file path. And I don't think it is a good
idea to create a symlink since the path may be changed as a result of
users operation.
I left it as "todo" because such long path is rare.
If you have an idea to show users any file path which may be changed
dynamically, please let me know. At the beginning I have tried procfs,
but I was told that newer module should use sysfs instead of procfs. If
sysfs doesn't suit a path, what should I use? Debugfs?
> Please, use debugfs for this. sysfs is a "one value per file" type
> filesystem. You should never be using the seqfile interface for a sysfs
> file, that's a sure sign something is wrong in your design.
>
> I think I'll stop reading now :(
I will change some entries which doesn't contain a file path (or make
them not to have have) and post again. So please don't stop reading.
J. R. Okajima
next prev parent reply other threads:[~2009-03-17 3:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 7:20 [RFC Aufs2 #2 00/28] source files J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 01/28] aufs documents J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 02/28] aufs public header file J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 03/28] aufs module global J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 04/28] aufs super_block J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 05/28] aufs branch directory/filesystem J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 06/28] aufs xino J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 07/28] aufs object lifetime management via sysfs J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 08/28] aufs mount options/flags J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 09/28] aufs workqueue J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 10/28] aufs sub-VFS J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 11/28] aufs sub-dcache J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 12/28] aufs copy-up J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 13/28] aufs whiteout J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 14/28] aufs pseudo-link J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 15/28] aufs policies to select one among multiple writable branches J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 16/28] aufs dentry and lookup J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 17/28] aufs file J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 18/28] aufs direcotry J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 19/28] aufs inode J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 20/28] aufs ioctl J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 21/28] aufs sysfs entries J. R. Okajima
2009-03-16 18:05 ` Greg KH
2009-03-17 3:26 ` hooanon05 [this message]
2009-03-17 3:37 ` Greg KH
2009-03-17 4:05 ` hooanon05
2009-03-17 4:22 ` Greg KH
2009-03-17 4:50 ` hooanon05
2009-03-17 10:39 ` Evgeniy Polyakov
2009-03-17 12:56 ` hooanon05
2009-03-19 8:04 ` hooanon05
2009-03-16 7:20 ` [RFC Aufs2 #2 22/28] aufs branch for loopback block device J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 23/28] aufs internal inotify J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 24/28] aufs test for fstype J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 25/28] aufs debug J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 26/28] export splice functions J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 27/28] export lookup functions J. R. Okajima
2009-03-16 7:20 ` [RFC Aufs2 #2 28/28] kbuild aufs J. R. Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7200.1237260402@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).