From: Fan Wu <wufan@linux.microsoft.com>
To: Christian Brauner <brauner@kernel.org>,
Phillip Lougher <phillip@squashfs.org.uk>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/4] Squashfs: Ensure all readahead pages have been used
Date: Fri, 23 Aug 2024 14:02:49 -0700 [thread overview]
Message-ID: <727eebc5-e01e-4737-88b8-9890d90abc39@linux.microsoft.com> (raw)
In-Reply-To: <20240821-erfinden-gegeben-be787ce7eb3b@brauner>
On 8/21/2024 1:12 AM, Christian Brauner wrote:
> On Wed, 21 Aug 2024 00:26:22 +0100, Phillip Lougher wrote:
>> In the recent work to remove page->index, a sanity check
>> that ensured all the readhead pages were covered by the
>> Squashfs data block was removed [1].
>>
>> To avoid any regression, this commit adds the sanity check
>> back in an equivalent way. Namely the page actor will now
>> return error if any pages are unused after completion.
>>
>> [...]
>
> Applied to the vfs.folio branch of the vfs/vfs.git tree.
> Patches in the vfs.folio branch should appear in linux-next soon.
>
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
>
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.folio
>
> [5/5] Squashfs: Ensure all readahead pages have been used
> https://git.kernel.org/vfs/vfs/c/5d85f9c952d8
>
When I was testing the linux-next branch I got
"BUG: KASAN: slab-use-after-free in squashfs_readahead+0x19f1/0x1e50"
It seems this is due to the access of `actor` just after freeing it.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/squashfs/page_actor.h#n41
-Fan
prev parent reply other threads:[~2024-08-23 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 23:26 [PATCH 5/4] Squashfs: Ensure all readahead pages have been used Phillip Lougher
2024-08-21 8:12 ` Christian Brauner
2024-08-23 21:02 ` Fan Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=727eebc5-e01e-4737-88b8-9890d90abc39@linux.microsoft.com \
--to=wufan@linux.microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).