From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com ([119.145.14.66]:10001 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbdALLSf (ORCPT ); Thu, 12 Jan 2017 06:18:35 -0500 Subject: Re: [f2fs-dev] [PATCH 04/10] f2fs: support IO alignment for DATA and NODE writes To: Jaegeuk Kim References: <20161230185117.3832-1-jaegeuk@kernel.org> <20161230185117.3832-4-jaegeuk@kernel.org> <7920f143-750a-69df-f4b3-eeac82c1014b@huawei.com> <20170104234444.GD1011@jaegeuk.local> CC: , , From: Chao Yu Message-ID: <72d90cfd-4496-ad66-bd02-74b4e570c7ac@huawei.com> Date: Thu, 12 Jan 2017 19:15:07 +0800 MIME-Version: 1.0 In-Reply-To: <20170104234444.GD1011@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2017/1/5 7:44, Jaegeuk Kim wrote: > On 01/04, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/12/31 2:51, Jaegeuk Kim wrote: >>> This patch implements IO alignment by filling dummy blocks in DATA and NODE >>> write bios. If we can guarantee, for example, 32KB or 64KB for such the IOs, >>> we can eliminate underlying dummy page problem which FTL conducts in order to >>> close MLC or TLC partial written pages. >>> >>> Note that, >>> - it requires "-o mode=lfs". >>> - IO size should be power of 2, not exceed BIO_MAX_PAGES, 256. >>> - read IO is still 4KB. >>> - do checkpoint at fsync, if dummy NODE page was written. >> >> Which scenario we can benefit from? Any numbers? > > I described it in the patch. This is not targetting for performance improvement > for now, but to address the dummy page write problem in FTL so that we can later > implement very simple host-level FTL on top of open-channel SSD. Alright, if we are doing this since FTL implementation is moved up, so I can understand that. Thanks, > >> I doubt that there are some potential side-effect points: >> - write amplification will be more serious than before >> - free space will be more fragmented since dummy blocks is separated in whole >> address space >> - there is less chance to merge small(unaligned) IOs in block layer > > I agree, so I just added this as a mount option experimentally. > One point would be that, if f2fs doesn't do this, FTL should do it. So I think, > from the system point of view, f2fs is a better layer to do it. > > Thanks, > >> >> Thoughts? >> >> Thanks, > > . >