linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	corbet@lwn.net, jake@lwn.net, hch@infradead.org,
	djwong@kernel.org, dchinner@redhat.com
Cc: ritesh.list@gmail.com, rgoldwyn@suse.com, jack@suse.cz,
	linux-doc@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	p.raghav@samsung.com, da.gomez@samsung.com,
	rohan.puri@samsung.com
Subject: Re: [PATCH] Documentation: add initial iomap kdoc
Date: Fri, 19 May 2023 08:13:50 -0700	[thread overview]
Message-ID: <731a3061-973c-a4ad-2fe5-7981c6c1279b@infradead.org> (raw)
In-Reply-To: <ZGdBO6bmbj3sLlzp@debian.me>



On 5/19/23 02:28, Bagas Sanjaya wrote:
>> +/**
>> + * DOC:  Flags reported by the file system from iomap_begin
>>   *
>> - * IOMAP_F_NEW indicates that the blocks have been newly allocated and need
>> - * zeroing for areas that no data is copied to.
>> + * * IOMAP_F_NEW: indicates that the blocks have been newly allocated and need
>> + *	zeroing for areas that no data is copied to.
>>   *
>> - * IOMAP_F_DIRTY indicates the inode has uncommitted metadata needed to access
>> - * written data and requires fdatasync to commit them to persistent storage.
>> - * This needs to take into account metadata changes that *may* be made at IO
>> - * completion, such as file size updates from direct IO.
>> + * * IOMAP_F_DIRTY: indicates the inode has uncommitted metadata needed to access
>> + *	written data and requires fdatasync to commit them to persistent storage.
>> + *	This needs to take into account metadata changes that *may* be made at IO
>> + *	completion, such as file size updates from direct IO.
>>   *
>> - * IOMAP_F_SHARED indicates that the blocks are shared, and will need to be
>> - * unshared as part a write.
>> + * * IOMAP_F_SHARED: indicates that the blocks are shared, and will need to be
>> + *	unshared as part a write.
>>   *
>> - * IOMAP_F_MERGED indicates that the iomap contains the merge of multiple block
>> - * mappings.
>> + * * IOMAP_F_MERGED: indicates that the iomap contains the merge of multiple block
>> + *	mappings.
>>   *
>> - * IOMAP_F_BUFFER_HEAD indicates that the file system requires the use of
>> - * buffer heads for this mapping.
>> + * * IOMAP_F_BUFFER_HEAD: indicates that the file system requires the use of
>> + *	buffer heads for this mapping.
>>   *
>> - * IOMAP_F_XATTR indicates that the iomap is for an extended attribute extent
>> - * rather than a file data extent.
>> + * * IOMAP_F_XATTR: indicates that the iomap is for an extended attribute extent
>> + *	rather than a file data extent.
>>   */
> Why don't use kernel-doc comments to describe flags?
> 

Because kernel-doc handles functions, structs, unions, and enums.
Not defines.

-- 
~Randy

  reply	other threads:[~2023-05-19 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 14:40 [PATCH] Documentation: add initial iomap kdoc Luis Chamberlain
2023-05-18 14:48 ` Christoph Hellwig
2023-05-18 14:50   ` Luis Chamberlain
2023-05-18 14:51     ` Christoph Hellwig
2023-05-18 14:54       ` Jonathan Corbet
2023-05-19  3:15       ` Theodore Ts'o
2023-05-19  9:28 ` Bagas Sanjaya
2023-05-19 15:13   ` Randy Dunlap [this message]
2023-05-19 23:25     ` Dave Chinner
2023-05-21 16:43       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=731a3061-973c-a4ad-2fe5-7981c6c1279b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=da.gomez@samsung.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jake@lwn.net \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=rgoldwyn@suse.com \
    --cc=ritesh.list@gmail.com \
    --cc=rohan.puri@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).