From: Qu Wenruo <wqu@suse.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Cc: "brauner@kernel.org" <brauner@kernel.org>,
	"djwong@kernel.org" <djwong@kernel.org>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] iomap: add IOMAP_DIO_FSBLOCK_ALIGNED flag
Date: Tue, 14 Oct 2025 07:09:10 +1030	[thread overview]
Message-ID: <737baeb0-93cd-4018-9013-c86c662a608e@suse.com> (raw)
In-Reply-To: <cda26765-066d-4e4f-bd8e-83263f1aee82@wdc.com>
在 2025/10/13 21:44, Johannes Thumshirn 写道:
> On 10/13/25 11:05 AM, Qu Wenruo wrote:
>> - Remove the btrfs part that utilize the new flag
>>     Now it's in the enablement patch of btrfs' bs > ps direct IO support.
> 
> But then we potentially have code merged without a user. I think it is
> better to have the btrfs patch in the same series and merged via the
> same tree.
> 
It's fine, and in fact that already happened, for the remove_bdev() 
callback.
So I'm more or less fine with that, as long as we have a proper plan to 
add the initial user.
Thanks,
Qu
next prev parent reply	other threads:[~2025-10-13 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13  9:05 [PATCH v2] iomap: add IOMAP_DIO_FSBLOCK_ALIGNED flag Qu Wenruo
2025-10-13 11:14 ` Johannes Thumshirn
2025-10-13 20:39   ` Qu Wenruo [this message]
2025-10-14  4:36 ` Christoph Hellwig
2025-10-14  4:55   ` Qu Wenruo
2025-10-14  4:58     ` Christoph Hellwig
2025-10-14  5:10       ` Qu Wenruo
2025-10-16 12:10 ` Pankaj Raghav (Samsung)
2025-10-21 13:03 ` Christian Brauner
2025-10-22  7:23   ` Christoph Hellwig
2025-10-29 12:45     ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=737baeb0-93cd-4018-9013-c86c662a608e@suse.com \
    --to=wqu@suse.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).