From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFD3C433EF for ; Wed, 9 Mar 2022 18:39:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232653AbiCISkP (ORCPT ); Wed, 9 Mar 2022 13:40:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbiCISkO (ORCPT ); Wed, 9 Mar 2022 13:40:14 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 42221156C4F for ; Wed, 9 Mar 2022 10:39:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646851152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TU5GSQcUsGsLm0QedmIo4Msii85jhaXsQwdtUQuJMSQ=; b=BfkZNLaOkHZ5OVFXQqO2MYD70GZDpbnMeLFrOHhVJV6TQodhfmd2VY1e/VGKGaIJrzknRw AEQFrwdUzWCPpEI786+c6ssBxHIthwRnlSBfnkeV8Jxne1kZnyFnCB03/2R/DZPMNkSA/J jyzV+vre8pP+S2oJrBsM9RbynloTClY= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-467-kU2dOzFvM8WSWDZ-JOSzNQ-1; Wed, 09 Mar 2022 13:39:10 -0500 X-MC-Unique: kU2dOzFvM8WSWDZ-JOSzNQ-1 Received: by mail-qv1-f72.google.com with SMTP id b3-20020a056214134300b004352de5b5f0so2782858qvw.20 for ; Wed, 09 Mar 2022 10:39:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=TU5GSQcUsGsLm0QedmIo4Msii85jhaXsQwdtUQuJMSQ=; b=0xHhJRG3rKirW4b4qFthvTIW1RVnaf8sd+wfr7Ny/svcpjqfnmYGIPGjAzvdmW36ya 4j4Y/0ilGud/FD0Kkh+epzzVHLEHHkS9ebi5A7E3JsF6uOcO9DD3EXAymKVnLDSADlwO HieUIB/ApLAvDpJMsE8bq/c+9Qz7JQiumB9MGQCGADzeDWznI5GB9cKrDpdRTYw5/cbA tE63+3RC6ecmQJljcIZXSkCabtY64XyuU4WNUpDCuIZz4oHxU/Ezu5arrFBv2Ezxmq9h E/LLDQBHYwGgRlQRj0IHLlVz4zsfY0M5NZO3uwVq97BcjMk48GddDsgCpI6Zz6j+6Vx4 alGg== X-Gm-Message-State: AOAM530ZDfY2KIpaclsiA1CFCdekTKOw9UBQ12dQKCn2vFygpW1JWScn 05O90MrZXhsfF6kp1xd073k+YpTfsMr33LYrmsglei7yQkYNw/qaLxfaTtl+s4v3z0DgCfhITVb UAOfEsi71YolQMAMTFNjCEAcHbw== X-Received: by 2002:a05:6214:d44:b0:435:b8fd:b1d7 with SMTP id 4-20020a0562140d4400b00435b8fdb1d7mr808165qvr.19.1646851150315; Wed, 09 Mar 2022 10:39:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzICtIC42Xa9GHFyHP+MaqIARsvCbO2mnHxe/nMuAl463CulcS9BHk/JL6v+PefmyNOF/kr8A== X-Received: by 2002:a05:6214:d44:b0:435:b8fd:b1d7 with SMTP id 4-20020a0562140d4400b00435b8fdb1d7mr808157qvr.19.1646851150152; Wed, 09 Mar 2022 10:39:10 -0800 (PST) Received: from [192.168.1.3] (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id t7-20020a05622a180700b002e0ccf0aa49sm1829549qtc.62.2022.03.09.10.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 10:39:09 -0800 (PST) Message-ID: <737c8db7461567ec04d5e2a7dbec58b699f8f16c.camel@redhat.com> Subject: Re: [PATCH v2 02/19] netfs: Generate enums from trace symbol mapping lists From: Jeff Layton To: David Howells Cc: linux-cachefs@redhat.com, Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , Ilya Dryomov , Jeffle Xu , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 09 Mar 2022 13:39:08 -0500 In-Reply-To: <1712592.1646840957@warthog.procyon.org.uk> References: <164678185692.1200972.597611902374126174.stgit@warthog.procyon.org.uk> <164678192454.1200972.4428834328108580460.stgit@warthog.procyon.org.uk> <1712592.1646840957@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, 2022-03-09 at 15:49 +0000, David Howells wrote: > Jeff Layton wrote: > > > Should you undef EM and E_ here after creating these? > > Maybe. So far it hasn't mattered... > I wasn't suggesting there was a bug there, more just a code hygiene thing. With macro names as generic as that (especially), it'd probably be good to undef them once you're done. -- Jeff Layton