From: Randy Dunlap <rdunlap@infradead.org>
To: Yang Li <yang.lee@linux.alibaba.com>, axboe@kernel.dk
Cc: hch@lst.de, bvanassche@acm.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fs/hfsplus: Fix some kernel-doc comments
Date: Tue, 30 Aug 2022 16:58:45 -0700 [thread overview]
Message-ID: <74683697-df9f-6f8f-00eb-4bb25e1a1638@infradead.org> (raw)
In-Reply-To: <20220830074223.20281-1-yang.lee@linux.alibaba.com>
On 8/30/22 00:42, Yang Li wrote:
> Add the description of @opf and remove @op and @op_flags in
> hfsplus_submit_bio() kernel-doc comment.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2013
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/hfsplus/wrapper.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
> index 0b791adf02e5..6202e877f459 100644
> --- a/fs/hfsplus/wrapper.c
> +++ b/fs/hfsplus/wrapper.c
> @@ -30,8 +30,7 @@ struct hfsplus_wd {
> * @sector: block to read or write, for blocks of HFSPLUS_SECTOR_SIZE bytes
> * @buf: buffer for I/O
> * @data: output pointer for location of requested data
> - * @op: direction of I/O
> - * @op_flags: request op flags
> + * @opf: operation and flags for bio
> *
> * The unit of I/O is hfsplus_min_io_size(sb), which may be bigger than
> * HFSPLUS_SECTOR_SIZE, and @buf must be sized accordingly. On reads
--
~Randy
prev parent reply other threads:[~2022-08-30 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 7:42 [PATCH -next] fs/hfsplus: Fix some kernel-doc comments Yang Li
2022-08-30 23:58 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74683697-df9f-6f8f-00eb-4bb25e1a1638@infradead.org \
--to=rdunlap@infradead.org \
--cc=abaci@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).