From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 06/43] FS-Cache: Recruit a couple of page flags for cache management [ver #46] Date: Thu, 02 Apr 2009 18:40:57 +0100 Message-ID: <7516.1238694057@redhat.com> References: <200904030431.04079.nickpiggin@yahoo.com.au> <200904030353.17713.nickpiggin@yahoo.com.au> <200904030315.03606.nickpiggin@yahoo.com.au> <7249.1238692155@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org To: Nick Piggin Return-path: In-Reply-To: <200904030431.04079.nickpiggin@yahoo.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org Nick Piggin wrote: > Well in theory I still think it would be cleanest to modify buffer to > play more nicely with it. But maybe that ends up being harder to > distinguish the 3 cases of attached metadata on the page. I don't know, > you haven't posted any isofs code so either way it is inappropriate to > use up this extra page flag here. > > Is isofs cache worth a page flag? Well, isofs was something I wanted at the time. Besides, as I said NFS uses PG_private for its own purposes, and entangling the two wasn't the most fun I've had. Trond didn't like it either. David