* Q. FMODE_NONOTIFY warning
@ 2010-08-18 13:39 J. R. Okajima
2011-01-19 19:21 ` Eric Paris
0 siblings, 1 reply; 2+ messages in thread
From: J. R. Okajima @ 2010-08-18 13:39 UTC (permalink / raw)
To: eparis; +Cc: linux-fsdevel
By the commit
ecf081d 2010-07-28 vfs: introduce FMODE_NONOTIFY
a new warning is produced.
In include/linux/fs.h
#define FMODE_NONOTIFY ((__force fmode_t)0x1000000)
:::
#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \
(flag & FMODE_NONOTIFY)))
In fs/anon_inodes.c
anon_inode_getfile(..., int flags)
{
file = alloc_file(&path, OPEN_FMODE(flags), fops);
}
Here the '&' operator handles the passed integer "flags" and "__force
fmode_t", and we get "warning: restricted fmode_t degrades to integer".
Can we stop this warning?
J. R. Okajima
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Q. FMODE_NONOTIFY warning
2010-08-18 13:39 Q. FMODE_NONOTIFY warning J. R. Okajima
@ 2011-01-19 19:21 ` Eric Paris
0 siblings, 0 replies; 2+ messages in thread
From: Eric Paris @ 2011-01-19 19:21 UTC (permalink / raw)
To: J. R. Okajima; +Cc: linux-fsdevel
On Wed, 2010-08-18 at 22:39 +0900, J. R. Okajima wrote:
> By the commit
> ecf081d 2010-07-28 vfs: introduce FMODE_NONOTIFY
> a new warning is produced.
>
> In include/linux/fs.h
> #define FMODE_NONOTIFY ((__force fmode_t)0x1000000)
> :::
> #define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \
> (flag & FMODE_NONOTIFY)))
>
> In fs/anon_inodes.c
> anon_inode_getfile(..., int flags)
> {
> file = alloc_file(&path, OPEN_FMODE(flags), fops);
> }
>
> Here the '&' operator handles the passed integer "flags" and "__force
> fmode_t", and we get "warning: restricted fmode_t degrades to integer".
>
> Can we stop this warning?
I apologize that this e-mail (along with many others) got put in my spam
folder and I'm responding months and months late. I don't believe this
is a problem upstream any longer. Thanks for the report and I'm sorry I
didn't respond....
-Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-19 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 13:39 Q. FMODE_NONOTIFY warning J. R. Okajima
2011-01-19 19:21 ` Eric Paris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).