From: John Hubbard <jhubbard@nvidia.com>
To: Jan Kara <jack@suse.cz>, <john.hubbard@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Jerome Glisse <jglisse@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Ralph Campbell <rcampbell@nvidia.com>
Subject: Re: [PATCH v5 2/3] mm: introduce put_user_page*(), placeholder versions
Date: Wed, 10 Oct 2018 11:35:51 -0700 [thread overview]
Message-ID: <75681b69-2db6-bc46-efe3-48d029c9ec22@nvidia.com> (raw)
In-Reply-To: <20181010080326.GB11507@quack2.suse.cz>
On 10/10/18 1:03 AM, Jan Kara wrote:
> On Tue 09-10-18 21:11:33, john.hubbard@gmail.com wrote:
>> +/*
>> + * put_user_pages() - for each page in the @pages array, release the page
>> + * using put_user_page().
>> + *
>> + * Please see the put_user_page() documentation for details.
>> + *
>> + * This is just like put_user_pages_dirty(), except that it invokes
>> + * set_page_dirty_lock(), instead of set_page_dirty().
>
> This paragraph should be deleted. Other than that the patch looks good.
>
Good catch. Fixed locally, and it will go up with the next spin.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2018-10-10 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 4:11 [PATCH v5 0/3] get_user_pages*() and RDMA: first steps john.hubbard
2018-10-10 4:11 ` [PATCH v5 1/3] mm: get_user_pages: consolidate error handling john.hubbard
2018-10-10 4:11 ` [PATCH v5 2/3] mm: introduce put_user_page*(), placeholder versions john.hubbard
2018-10-10 8:03 ` Jan Kara
2018-10-10 18:35 ` John Hubbard [this message]
2018-10-10 4:11 ` [PATCH v5 3/3] infiniband/mm: convert put_page() to put_user_page*() john.hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75681b69-2db6-bc46-efe3-48d029c9ec22@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=john.hubbard@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).