From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 757BF235061 for ; Wed, 2 Jul 2025 08:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751444731; cv=none; b=lTzNBUtCj8/563hPPXHON+nlngj+inabamZEDd4ZSANm+msxMPkX4mjR6wNXDpPCYSCCVeyLOKjJFSWAyVP/jLYG17RHZRwZ1ARMnIkJsgfiNEnUu74skN+NrLOYD3odRKAz2YFyv5ABc0Ua2rrntLWwzuwr8IUf0l07MKrJ/+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751444731; c=relaxed/simple; bh=Xk4+2auyH0AEtyXCiBJCzUGc6hCh0l3qcvQYN4X0PbQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LXiEPZCPJ3Tdsd474BoARwsbtLTTTiRNz30oa5uVofyBrzAnYUZqi0kRXq7O4WoqyFscaGSvb8QPCUEXl1JIhhSOMms3+VXx7yG+IIxjN7uAYC+yCleqCKm8DvdCneGDNn7MHTrtN3peNrWp80WJ1c334BHGi87VaSbApycOj0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eILuffrf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eILuffrf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751444728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OvDgMJR7If16brpfVPQ8a4d5ZRO1JM0Tn+iRiJR4jHY=; b=eILuffrfxP/4OvSOt84CDAdifZfymOJKyUyXIALRXP+RehsW4BC7JhesdMnBvfaMQ4i/49 Ry/jGFOtlVmnmkBdKUcOyBMdkbxdS+14JOsvJQpmpNxqgj5sf256hKZGnWAuxAvk1DMdTr XWTGTVPyXXzRxUGRVj3k64NwRyus5w4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-8eKUzAjOPZmBdls_8Q11vg-1; Wed, 02 Jul 2025 04:25:27 -0400 X-MC-Unique: 8eKUzAjOPZmBdls_8Q11vg-1 X-Mimecast-MFC-AGG-ID: 8eKUzAjOPZmBdls_8Q11vg_1751444726 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45320bfc18dso32795165e9.1 for ; Wed, 02 Jul 2025 01:25:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751444726; x=1752049526; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OvDgMJR7If16brpfVPQ8a4d5ZRO1JM0Tn+iRiJR4jHY=; b=ocbHSENDNuQCKjIHK7cex+vx0sDc3crWrIiM6/d9yKrUp84o0Ybhjbbihwzj2vWtYa /uqRSNxh/YiStEnha/WnfN04hgCEmdg/S8VZfYmfux3QBKOpvK84fB7BpGwLskQPDZju pEuox76EMHp6MtHhGhs0NaHk3dZ94/6DXxxZ6KObZAOkAjY9/P0St+Mv2oVMitGjGz4v Lnj/0cNvdB6hOkHPekYaOwA0w7M7AQvDG3+KMxUiUFhBufcXx+y85aXsHfFtgYbAzT4m RcMxGJGdpAy+bZ0YJeM9Re+HGDayMSIDLTQDwnsC2LOna4iX5/ZS4u6rVjKbaqnfrj5b 8xLQ== X-Forwarded-Encrypted: i=1; AJvYcCUsmG4y+pAKlCNBFZy6qALvmLwA2bWxoSgsXXi5Zl6LN8tIoohEd/ukgT8b4GGLwVe7iEXA97dEVYtGajTU@vger.kernel.org X-Gm-Message-State: AOJu0Yy/ubCJatJ7OCpMg53s+FtqmZBn4KXIOKI0a82kHSyrBZObEjyW TitB7LGPfkGIwGD348NEaNColZI9QOtFdJDThuvvnHPUxlNNRLZX9bmTRrCrE9uJWYu6Ha+sQIf Dsnd1cN2YKiA4cbBmgKIs4JpebNCHPq6ZOF6MAQaha3GaLMZnMhCYUiT8qwmpLkYKZ5g= X-Gm-Gg: ASbGncto2wIo8l/TPTvAq2r1UyqSdyRUTm1WBL/qnLnEjhpMJM2dkA5dirSed/AKGSG uuwoyA/vaAslqPYul08gQ8WlR9VyheQqJOCNPUU/TrLd2r+ZImKwI+ck3v6grDLxZFqmi7muSQ1 pADhA7KSnDL2sudwYF/qnQvWXY4gIiV2xc6OqeKCnY4WYEEVvgPNoSwU5xLwfThwm2mACF/iA6C WX4mW9eFP0SS0qHtlFg0xoOW7SZ3sTdTNezUWvv7A41u6vM72QsJc2rkWr8prfJQSWeZCnEO1U2 JqjjXwyzeN69FTyz3iybYr43qwvIu9aTR3C3v8keQCW+RlFn4A44Gxg= X-Received: by 2002:a05:600c:c0dc:b0:453:45f1:9c96 with SMTP id 5b1f17b1804b1-454a3c610camr13188315e9.14.1751444725673; Wed, 02 Jul 2025 01:25:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOJzOQgdPny8RvF9/NZMstcP4GmeGcDGHKxjBeQFmtTXoydP6Z6ks24gXdPezTJYYrWauOEA== X-Received: by 2002:a05:600c:c0dc:b0:453:45f1:9c96 with SMTP id 5b1f17b1804b1-454a3c610camr13187545e9.14.1751444725107; Wed, 02 Jul 2025 01:25:25 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a406489sm194158805e9.27.2025.07.02.01.25.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 01:25:24 -0700 (PDT) Message-ID: <757cf6b9-730b-4b12-9a3d-27699e20e3ac@redhat.com> Date: Wed, 2 Jul 2025 10:25:22 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 12/29] mm/zsmalloc: stop using __ClearPageMovable() To: Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-13-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.07.25 10:11, Sergey Senozhatsky wrote: > On (25/06/30 14:59), David Hildenbrand wrote: > [..] >> static int zs_page_migrate(struct page *newpage, struct page *page, >> @@ -1736,6 +1736,13 @@ static int zs_page_migrate(struct page *newpage, struct page *page, >> unsigned long old_obj, new_obj; >> unsigned int obj_idx; >> >> + /* >> + * TODO: nothing prevents a zspage from getting destroyed while >> + * isolated: we should disallow that and defer it. >> + */ > > Can you elaborate? We can only free a zspage in free_zspage() while the page is locked. After we isolated a zspage page for migration (under page lock!), we drop the lock again, to retake the lock when trying to migrate it. That means, there is a window where a zspage can be freed although the page is isolated for migration. While we currently keep that working (as far as I can see), in the future we want to remove that support from the core. So what probably needs to be done is, checking in free_zspage(), whether the page is isolated. If isolated, defer freeing to the putback/migration call. That way, it will be clear who the current owner of an object is (isolation makes mm core the owner, while putback returns ownership), and prepare for some pages to be migrated to have a permanently frozen refcount (esp PageOffline pages without any refcount). -- Cheers, David / dhildenb