From: Mike Kravetz <mike.kravetz@oracle.com>
To: Michal Hocko <mhocko@kernel.org>, Piotr Sarna <p.sarna@tlen.pl>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: add O_TMPFILE support
Date: Tue, 15 Oct 2019 16:37:00 -0700 [thread overview]
Message-ID: <766b4370-ba71-85a2-5a57-ca9ed7dc7870@oracle.com> (raw)
In-Reply-To: <20191015105055.GA24932@dhcp22.suse.cz>
On 10/15/19 3:50 AM, Michal Hocko wrote:
> On Tue 15-10-19 11:01:12, Piotr Sarna wrote:
>> With hugetlbfs, a common pattern for mapping anonymous huge pages
>> is to create a temporary file first.
>
> Really? I though that this is normally done by shmget(SHM_HUGETLB) or
> mmap(MAP_HUGETLB). Or maybe I misunderstood your definition on anonymous
> huge pages.
>
>> Currently libraries like
>> libhugetlbfs and seastar create these with a standard mkstemp+unlink
>> trick,
I would guess that much of libhugetlbfs was writen before MAP_HUGETLB
was implemented. So, that is why it does not make (more) use of that
option.
The implementation looks to be straight forward. However, I really do
not want to add more functionality to hugetlbfs unless there is specific
use case that needs it.
--
Mike Kravetz
next prev parent reply other threads:[~2019-10-15 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 9:01 [PATCH] hugetlbfs: add O_TMPFILE support Piotr Sarna
2019-10-15 10:50 ` Michal Hocko
2019-10-15 23:37 ` Mike Kravetz [this message]
2019-10-21 17:17 ` Mike Kravetz
2019-10-22 7:09 ` Piotr Sarna
2019-10-23 2:55 ` Mike Kravetz
2019-10-23 7:14 ` Piotr Sarna
2019-10-28 18:56 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=766b4370-ba71-85a2-5a57-ca9ed7dc7870@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=p.sarna@tlen.pl \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).