From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chuck Lever" Subject: Re: [PATCH 5/7] NFS: Use local caching [try #12] Date: Fri, 18 Aug 2006 11:43:00 -0400 Message-ID: <76bd70e30608180843m536e9f57y90e1915f40f85b2@mail.gmail.com> References: <20060818153502.29482.91650.stgit@warthog.cambridge.redhat.com> <20060818153514.29482.78513.stgit@warthog.cambridge.redhat.com> Reply-To: Linux filesystem caching discussion list Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, nfsv4@linux-nfs.org, trond.myklebust@fys.uio.no, torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org Return-path: To: "David Howells" In-Reply-To: <20060818153514.29482.78513.stgit@warthog.cambridge.redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cachefs-bounces@redhat.com Errors-To: linux-cachefs-bounces@redhat.com List-Id: linux-fsdevel.vger.kernel.org Hi David- On 8/18/06, David Howells wrote: > The attached patch makes it possible for the NFS filesystem to make use of the > network filesystem local caching service (FS-Cache). > > To be able to use this, an updated mount program is required. This can be > obtained from: > > http://people.redhat.com/steved/cachefs/util-linux/ > > To mount an NFS filesystem to use caching, add an "fsc" option to the mount: > > mount warthog:/ /a -o fsc > > Signed-Off-By: David Howells > --- > > fs/Kconfig | 7 + > fs/nfs/Makefile | 1 > fs/nfs/client.c | 11 + > fs/nfs/file.c | 49 ++++- > fs/nfs/fscache.c | 348 ++++++++++++++++++++++++++++++++ > fs/nfs/fscache.h | 476 ++++++++++++++++++++++++++++++++++++++++++++ > fs/nfs/inode.c | 21 ++ > fs/nfs/internal.h | 32 +++ > fs/nfs/pagelist.c | 3 > fs/nfs/read.c | 30 +++ > fs/nfs/super.c | 1 > fs/nfs/sysctl.c | 43 ++++ > fs/nfs/write.c | 11 + > include/linux/nfs4_mount.h | 1 > include/linux/nfs_fs.h | 5 > include/linux/nfs_fs_sb.h | 5 > include/linux/nfs_mount.h | 1 > 17 files changed, 1035 insertions(+), 10 deletions(-) > > diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c > new file mode 100644 > index 0000000..94d5e3a > --- /dev/null > +++ b/fs/nfs/fscache.c > @@ -0,0 +1,348 @@ > +/* fscache.c: NFS filesystem cache interface > + * > + * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells@redhat.com) > + * > + > +static uint16_t nfs_server_get_key(const void *cookie_netfs_data, > + void *buffer, uint16_t bufmax) > +{ Why don't you use the function declaration style that is used in the rest of the NFS client? All the parameters belong on one line, don't they? -- "We who cut mere stones must always be envisioning cathedrals" -- Quarry worker's creed