linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: Alex Markuze <amarkuze@redhat.com>
Cc: Viacheslav Dubeyko <vdubeyko@redhat.com>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"idryomov@gmail.com" <idryomov@gmail.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH v3 4/4] ceph: adding CEPH_SUBVOLUME_ID_NONE
Date: Wed, 3 Dec 2025 22:54:51 +0000	[thread overview]
Message-ID: <7720f7ee8f8e8289c8e5346c2b129de2592e2d64.camel@ibm.com> (raw)
In-Reply-To: <CAO8a2SjQDC2qaVV6_jsQbzOtUUdxStx2jEMYkG3VVkSCPbiH_Q@mail.gmail.com>

On Wed, 2025-12-03 at 23:22 +0200, Alex Markuze wrote:
> The latest ceph code supports subvolume metrics.
> The test is simple:
> 1. Deploy a ceph cluster
> 2. Create and mount a subvolume
> 3. run some I/O
> 4. I used debugfs to see that subvolume metrics were collected on the
> client side and checked for subvolume metrics being reported on the
> mds.
> 
> Nothing more to it.
> 

So, if it is simple, then what's about of adding another Ceph's test into
xfstests suite? Maybe, you can consider unit-test too. I've already introduced
initial patch with Kunit-based unit-test. We should have some test-case that
anyone can run and test this code.

Thanks,
Slava.


  reply	other threads:[~2025-12-03 22:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-03 15:46 [PATCH v3 0/4] ceph: add subvolume metrics reporting support Alex Markuze
2025-12-03 15:46 ` [PATCH v3 1/4] ceph: handle InodeStat v8 versioned field in reply parsing Alex Markuze
2025-12-03 15:46 ` [PATCH v3 2/4] ceph: parse subvolume_id from InodeStat v9 and store in inode Alex Markuze
2025-12-03 15:46 ` [PATCH v3 3/4] ceph: add subvolume metrics collection and reporting Alex Markuze
2025-12-03 15:46 ` [PATCH v3 4/4] ceph: adding CEPH_SUBVOLUME_ID_NONE Alex Markuze
2025-12-03 20:15   ` Viacheslav Dubeyko
2025-12-03 21:22     ` Alex Markuze
2025-12-03 22:54       ` Viacheslav Dubeyko [this message]
2025-12-04  8:18         ` Alex Markuze
2025-12-04 18:53           ` Viacheslav Dubeyko
2025-12-07 10:51             ` Alex Markuze
2025-12-12  0:14   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7720f7ee8f8e8289c8e5346c2b129de2592e2d64.camel@ibm.com \
    --to=slava.dubeyko@ibm.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=vdubeyko@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).