From: David Howells <dhowells@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: David Howells <dhowells@redhat.com>, Jens Axboe <axboe@suse.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BLOCK: Make it possible to disable the block layer
Date: Thu, 24 Aug 2006 14:34:16 +0100 [thread overview]
Message-ID: <778.1156426456@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <1156425193.3012.32.camel@pmac.infradead.org>
David Woodhouse <dwmw2@infradead.org> wrote:
> > (*) The contents of a number of filesystem- and blockdev-specific header
> > files are now contingent on their own configuration options. This
> > includes: Ext3/JBD, RAID, MSDOS and ReiserFS.
>
> Why? Those header files shouldn't be included from anywhere _but_ the
> code in question,
Go and look at fs/compat_ioctl.c.
> and in fact should probably be just moved into fs/foo instead of living in
> include/linux/foo_fs.h.
Definitely. Patches please:-)
> And please, _never_ make anything dependent on CONFIG_foo_MODULE.
Ah, but... The core kernel makes use of the certain header files, even when
their actual intended target is compiled as a module. If I just use
"CONFIG_foo" only, then the module won't compile as a module.
David
next prev parent reply other threads:[~2006-08-24 13:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 13:00 [PATCH] BLOCK: Make it possible to disable the block layer David Howells
2006-08-24 13:13 ` David Woodhouse
2006-08-24 13:34 ` David Howells [this message]
2006-08-24 13:40 ` David Woodhouse
2006-08-24 13:54 ` David Howells
2006-08-24 13:47 ` Christoph Hellwig
2006-08-24 14:42 ` Nick Piggin
2006-08-24 15:29 ` Adrian Bunk
2006-08-24 15:44 ` David Woodhouse
2006-08-24 15:58 ` Adrian Bunk
2006-08-24 16:00 ` David Woodhouse
2006-08-24 16:09 ` Adrian Bunk
2006-08-24 16:47 ` Alexey Dobriyan
2006-08-24 17:07 ` Adrian Bunk
2006-08-24 17:16 ` David Woodhouse
2006-08-24 17:34 ` Randy.Dunlap
2006-08-24 17:48 ` David Woodhouse
2006-08-24 17:59 ` Sam Ravnborg
2006-08-25 6:23 ` Jan Engelhardt
2006-08-25 7:19 ` Sam Ravnborg
2006-08-24 18:01 ` Randy.Dunlap
2006-08-25 6:21 ` Jan Engelhardt
2006-08-25 6:07 ` Jan Engelhardt
2006-08-25 10:37 ` Adrian Bunk
2006-08-25 13:09 ` Alexey Dobriyan
2006-08-24 16:39 ` Jan Engelhardt
2006-08-24 16:44 ` David Woodhouse
2006-08-24 16:48 ` Adrian Bunk
2006-08-24 21:31 ` Johannes Stezenbach
2006-08-25 6:04 ` Jan Engelhardt
2006-08-24 18:39 ` Matthias Schniedermeyer
2006-08-25 6:06 ` Jan Engelhardt
2006-08-24 17:18 ` David Howells
2006-08-24 17:23 ` Adrian Bunk
2006-08-24 16:23 ` Stefan Richter
2006-08-25 12:16 ` Jens Axboe
2006-08-25 13:40 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778.1156426456@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=axboe@suse.de \
--cc=dwmw2@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).