From: "André Draszik" <andre.draszik@linaro.org>
To: Song Liu <song@kernel.org>,
bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: kernel-team@meta.com, andrii@kernel.org, eddyz87@gmail.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
kpsingh@kernel.org, mattbobrowski@google.com,
amir73il@gmail.com, gregkh@linuxfoundation.org, tj@kernel.org,
daan.j.demeyer@gmail.com,
Will McVicker <willmcvicker@google.com>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
kernel-team@android.com
Subject: Re: [PATCH v3 bpf-next 1/4] kernfs: remove iattr_mutex
Date: Wed, 02 Jul 2025 11:47:58 +0100 [thread overview]
Message-ID: <78b13bcdae82ade95e88f315682966051f461dde.camel@linaro.org> (raw)
In-Reply-To: <20250623063854.1896364-2-song@kernel.org>
Hi,
On Sun, 2025-06-22 at 23:38 -0700, Song Liu wrote:
> From: Christian Brauner <brauner@kernel.org>
>
> All allocations of struct kernfs_iattrs are serialized through a global
> mutex. Simply do a racy allocation and let the first one win. I bet most
> callers are under inode->i_rwsem anyway and it wouldn't be needed but
> let's not require that.
>
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Song Liu <song@kernel.org>
On next-20250701, ls -lA gives errors on /sys:
$ ls -lA /sys/
ls: /sys/: No data available
ls: /sys/kernel: No data available
ls: /sys/power: No data available
ls: /sys/class: No data available
ls: /sys/devices: No data available
ls: /sys/dev: No data available
ls: /sys/hypervisor: No data available
ls: /sys/fs: No data available
ls: /sys/bus: No data available
ls: /sys/firmware: No data available
ls: /sys/block: No data available
ls: /sys/module: No data available
total 0
drwxr-xr-x 2 root root 0 Jan 1 1970 block
drwxr-xr-x 52 root root 0 Jan 1 1970 bus
drwxr-xr-x 88 root root 0 Jan 1 1970 class
drwxr-xr-x 4 root root 0 Jan 1 1970 dev
drwxr-xr-x 11 root root 0 Jan 1 1970 devices
drwxr-xr-x 3 root root 0 Jan 1 1970 firmware
drwxr-xr-x 10 root root 0 Jan 1 1970 fs
drwxr-xr-x 2 root root 0 Jul 2 09:43 hypervisor
drwxr-xr-x 14 root root 0 Jan 1 1970 kernel
drwxr-xr-x 251 root root 0 Jan 1 1970 module
drwxr-xr-x 3 root root 0 Jul 2 09:43 power
and my bisect is pointing to this commit. Simply reverting it also fixes
the errors.
Do you have any suggestions?
Cheers,
Andre'
next prev parent reply other threads:[~2025-07-02 10:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 6:38 [PATCH v3 bpf-next 0/4] Introduce bpf_cgroup_read_xattr Song Liu
2025-06-23 6:38 ` [PATCH v3 bpf-next 1/4] kernfs: remove iattr_mutex Song Liu
2025-07-02 10:47 ` André Draszik [this message]
2025-07-02 12:17 ` Christian Brauner
2025-07-03 6:28 ` André Draszik
2025-08-16 5:52 ` Jan Kiszka
2025-08-19 10:05 ` Christian Brauner
2025-08-19 10:08 ` [PATCH] kernfs: don't fail listing extended attributes Christian Brauner
2025-06-23 6:38 ` [PATCH v3 bpf-next 2/4] bpf: Introduce bpf_cgroup_read_xattr to read xattr of cgroup's node Song Liu
2025-06-23 6:38 ` [PATCH v3 bpf-next 3/4] bpf: Mark cgroup_subsys_state->cgroup RCU safe Song Liu
2025-06-23 6:38 ` [PATCH v3 bpf-next 4/4] selftests/bpf: Add tests for bpf_cgroup_read_xattr Song Liu
2025-06-23 11:03 ` [PATCH v3 bpf-next 0/4] Introduce bpf_cgroup_read_xattr Christian Brauner
2025-06-27 2:14 ` Alexei Starovoitov
2025-06-27 4:04 ` Song Liu
2025-06-27 15:59 ` Alexei Starovoitov
2025-06-27 16:20 ` Song Liu
2025-07-01 8:32 ` Christian Brauner
2025-07-01 16:23 ` Song Liu
2025-07-02 12:19 ` Christian Brauner
2025-07-01 8:31 ` Christian Brauner
2025-07-01 14:51 ` Alexei Starovoitov
2025-07-02 8:37 ` Christian Brauner
2025-06-27 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b13bcdae82ade95e88f315682966051f461dde.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=amir73il@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=kernel-team@android.com \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=peter.griffin@linaro.org \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).