From: Jeff Layton <jlayton@kernel.org>
To: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
syzbot <syzbot+8073030e235a5a84dd31@syzkaller.appspotmail.com>,
asm@florahospitality.com, bfields@fieldses.org,
boqun.feng@gmail.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, syzkaller-bugs@googlegroups.com,
viro@zeniv.linux.org.uk, will@kernel.org
Subject: Re: [syzbot] possible deadlock in f_getown
Date: Thu, 23 Sep 2021 13:54:17 -0400 [thread overview]
Message-ID: <792f0377a0aa982ebb476be05eef5f21fd45c429.camel@kernel.org> (raw)
In-Reply-To: <ff026440-590e-6268-6ced-326f4da27be2@gmail.com>
On Thu, 2021-09-23 at 13:20 -0400, Desmond Cheong Zhi Xi wrote:
> On 23/9/21 2:03 am, syzbot wrote:
> > syzbot suspects this issue was fixed by commit:
> >
> > commit f671a691e299f58835d4660d642582bf0e8f6fda
> > Author: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> > Date: Fri Jul 2 09:18:30 2021 +0000
> >
> > fcntl: fix potential deadlocks for &fown_struct.lock
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15fa8017300000
> > start commit: 293837b9ac8d Revert "i915: fix remap_io_sg to verify the p..
> > git tree: upstream
> > kernel config: https://syzkaller.appspot.com/x/.config?x=18fade5827eb74f7
> > dashboard link: https://syzkaller.appspot.com/bug?extid=8073030e235a5a84dd31
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=171390add00000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10050553d00000
> >
> > If the result looks correct, please mark the issue as fixed by replying with:
> >
> > #syz fix: fcntl: fix potential deadlocks for &fown_struct.lock
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> >
>
> #syz fix: fcntl: fix potential deadlocks for &fown_struct.lock
>
> Think I got jumbled a bit when marking the dups. This bug shares the
> same root cause as [1], and is fixed by the same patch. Nice that Syzbot
> noticed.
>
> Link: https://syzkaller.appspot.com/bug?extid=e6d5398a02c516ce5e70 [1]
Yeah, I had forgotten about that syzkaller report entirely.
I'm not sure we can do much about it now that the patch is already
merged though. Is there a process for amending changelogs for patches
already in Linus' tree?
If I had gotten this email while it was still sitting in linux-next, I
would have added that line. The syzkaller folks might want to consider
occasionally doing these sorts of checks vs. linux-next to catch this
sort of thing, if they care about the attribution.
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2021-09-23 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 7:48 possible deadlock in f_getown syzbot
2020-11-30 12:39 ` syzbot
2020-11-30 19:23 ` syzbot
2021-09-23 6:03 ` [syzbot] " syzbot
2021-09-23 17:20 ` Desmond Cheong Zhi Xi
2021-09-23 17:54 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=792f0377a0aa982ebb476be05eef5f21fd45c429.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=asm@florahospitality.com \
--cc=bfields@fieldses.org \
--cc=boqun.feng@gmail.com \
--cc=desmondcheongzx@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=syzbot+8073030e235a5a84dd31@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).