From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA77D26A09F for ; Tue, 1 Jul 2025 08:27:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751358453; cv=none; b=sIpTb2nquWDdu8mLh125nRGeS9YWf9yZhbSl+Cwbrrq+d9OiaFVFRTg5lsxkLFGFdkAex1SgpOIgzaj8QdkxALRNG46FoQ8TrsoqoZAOCBXT2NNbyNB69OmJzBCiU8CkLxebwCR/PLI+s3d+mQhiw7D2dktlGjZ/0EEj8DRIGO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751358453; c=relaxed/simple; bh=okB2rk2HVuHJHZxkIKLd76X0fkW/h1m/f+FN8rsyfgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pb4G8WUOaE4VCvNTgAf3UMltoYnVky1vNsHB+SmA87608DDyPsWQhx22DI1MPSjZunWUEqV/VbcWehiy7SDQ8IjEnEAh5ZtIxIJOMGNC4Sy3zSNbSu9Twu5G3xxia1njmTGI36OrD01ChRlC2f8wpDzoXksggjq95qyJiO12x0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e+krFGMG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e+krFGMG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751358450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PblRiGjccU8Bn/mbQjlfjXdXmpQtgP9DOCLVx78Z5kk=; b=e+krFGMG7fmvox4a/P26DyUJIPlpcLf05E6BBS+NKMAnrOk02Ugp8d25nH/cH3qB94bWCn MIVM0MAuMGJ376pgcHctVB1Ii4iwUY4u10FAuZG6adZeTrg//exiudy6btH2QBnNb6mUIC ost63AJhWop86jRGPSlDn61OgjkeXaA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-uLqiFdVKMyqQ8nURkIBQwg-1; Tue, 01 Jul 2025 04:27:29 -0400 X-MC-Unique: uLqiFdVKMyqQ8nURkIBQwg-1 X-Mimecast-MFC-AGG-ID: uLqiFdVKMyqQ8nURkIBQwg_1751358448 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a54a8a0122so2642981f8f.2 for ; Tue, 01 Jul 2025 01:27:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751358448; x=1751963248; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PblRiGjccU8Bn/mbQjlfjXdXmpQtgP9DOCLVx78Z5kk=; b=j+HRzeAOe4H2bEeCDQjnPX4+YaR6ligsMEso0+3Fk+Xp9RQjBQhYNDjB9OlTR/2LQw fYdJjWa/LMcy4PZnaN7E8rAdv1C/YScN6I18GhQ4nS3UGJiBRGXcMvxez7Ixo5Hef1D0 Jk234ncaSXDQ6kEPOYhTvWlvk31xo649/EVHO1e63+kiJ2XUsmbdVqV1NCfMprFFhDTB QE4+huI9JLUxg0r6YAM7RyFC/JFJJdPuOx253jOCcj4YC0hzSI2rCzykyTao7Gsp38xg boLvYIMeLhskA4zmm06zsn0qzYUp7TUXxt0xtdxd0z3sK6iS/6LJgPUht9ND6xttkuXY Qs5Q== X-Forwarded-Encrypted: i=1; AJvYcCXPbZxzLPFabJs1aJzTGqzGULbbWWJONjpA1zobEbTs84xOLvKZK5p9msUJXIK9MOYlzMMIRVsZeS2/GJWv@vger.kernel.org X-Gm-Message-State: AOJu0Yzfe16Ht5RI1NgGFimTSnSfiG3K31i35M+I6r06ZPd7xDeSBtJ0 q5mnTLSsrdb0eZYqzCei2uBnGF5LpB+6XHY1n7DzHoVw9YxjjczuXnJiHuoP+ea+uqyZGmDhyLD Nz2aHAbSaRMd6emcZYwluSWl4aLJVjFZUlAuYXINBdj4vyjOH7FgjGDlw5x1liDAvNs8= X-Gm-Gg: ASbGncvKMluUZ7mYKpKaQVHxi6JQpeWebhpqBXr69njDL7NL0CJ/jtyYt78jPu4hoDI am5hQgne3X0aIXxAywKaBKPkHW5nBWHJlBwD4bZQSE0LnolfVCLYstk3XqBBkxa/FlPzfIOkY7w V7TVSa6DcjNnWuiS5eAwtmFd9LVj0gVeKj5AbKCuXJ8EyaCkJ5kmj5hETTDCQ95sRWI7uIy01LR AO62QpOP2nyE9RpnLNYQjLHj0v6E6PpFWsVydoDa9kfsHgTF847OekmYbOPR5WgWZ6KrIDf19Sl qnX7IQcgUZoWKYKmIe2O4irjxpkKS83IfVuDihSltuX7f7Ty2x+6k3a+hgafe5++HTgtWWJR70X QRbOy2d8GnbK21LQkyzmTFb9i1zOu8lYL3zCDbuviS7PzFQ4x+w== X-Received: by 2002:adf:ea49:0:b0:3a5:2cb5:6429 with SMTP id ffacd0b85a97d-3a9001a2429mr10713687f8f.43.1751358448204; Tue, 01 Jul 2025 01:27:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiLSGjG1SoIniYOMAMRtKjuH1JQxFUi7zwrUP3ZsrTTfWnOXH6/VrqPd9s71VjBfuaf4xFvw== X-Received: by 2002:adf:ea49:0:b0:3a5:2cb5:6429 with SMTP id ffacd0b85a97d-3a9001a2429mr10713626f8f.43.1751358447701; Tue, 01 Jul 2025 01:27:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52a35sm12732775f8f.57.2025.07.01.01.27.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 01:27:27 -0700 (PDT) Message-ID: <7a194ee3-f5c3-416e-8de2-d2beb32479a8@redhat.com> Date: Tue, 1 Jul 2025 10:27:24 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/29] mm/zsmalloc: make PageZsmalloc() sticky until the page is freed To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-7-david@redhat.com> <74894b3e-9a64-4600-aa3a-e212d2f63e1b@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <74894b3e-9a64-4600-aa3a-e212d2f63e1b@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.06.25 18:03, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 02:59:47PM +0200, David Hildenbrand wrote: >> Let the page freeing code handle clearing the page type. >> >> Acked-by: Zi Yan >> Reviewed-by: Sergey Senozhatsky >> Acked-by: Harry Yoo >> Signed-off-by: David Hildenbrand > > On basis of sanity of UINT_MAX thing: > > Reviewed-by: Lorenzo Stoakes > >> --- >> mm/zpdesc.h | 5 ----- >> mm/zsmalloc.c | 3 +-- >> 2 files changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/mm/zpdesc.h b/mm/zpdesc.h >> index 5cb7e3de43952..5763f36039736 100644 >> --- a/mm/zpdesc.h >> +++ b/mm/zpdesc.h >> @@ -163,11 +163,6 @@ static inline void __zpdesc_set_zsmalloc(struct zpdesc *zpdesc) >> __SetPageZsmalloc(zpdesc_page(zpdesc)); >> } >> >> -static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) >> -{ >> - __ClearPageZsmalloc(zpdesc_page(zpdesc)); >> -} >> - >> static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) >> { >> return page_zone(zpdesc_page(zpdesc)); >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c >> index 7f1431f2be98f..f98747aed4330 100644 >> --- a/mm/zsmalloc.c >> +++ b/mm/zsmalloc.c >> @@ -880,7 +880,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) >> ClearPagePrivate(page); >> zpdesc->zspage = NULL; >> zpdesc->next = NULL; >> - __ClearPageZsmalloc(page); >> + /* PageZsmalloc is sticky until the page is freed to the buddy. */ >> } >> >> static int trylock_zspage(struct zspage *zspage) >> @@ -1055,7 +1055,6 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, >> if (!zpdesc) { >> while (--i >= 0) { >> zpdesc_dec_zone_page_state(zpdescs[i]); > > Maybe for consistency put a > > /* PageZsmalloc is sticky until the page is freed to the buddy. */ > I'll add that inside free_zpdesc(), before the __free_page(). Thanks! -- Cheers, David / dhildenb