[PATCH] fs: autofs: add MODULE_DESCRIPTION()

[PATCH] fs: autofs: add MODULE_DESCRIPTION()

[Jeff Johnson]

Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/autofs/autofs4.o

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 fs/autofs/init.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/autofs/init.c b/fs/autofs/init.c
index b5e4dfa04ed0..1d644a35ffa0 100644
--- a/fs/autofs/init.c
+++ b/fs/autofs/init.c
@@ -38,4 +38,5 @@ static void __exit exit_autofs_fs(void)
 
 module_init(init_autofs_fs)
 module_exit(exit_autofs_fs)
+MODULE_DESCRIPTION("Kernel automounter support");
 MODULE_LICENSE("GPL");

---
base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
change-id: 20240527-md-fs-autofs-62625640557b

Re: [PATCH] fs: autofs: add MODULE_DESCRIPTION()

[Christian Brauner]

On Mon, 27 May 2024 12:22:16 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/autofs/autofs4.o
> 
> 

Applied to the v6.10-rc1 branch of the vfs/vfs.git tree.
Patches in the v6.10-rc1 branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: v6.10-rc1

[1/1] fs: autofs: add MODULE_DESCRIPTION()
      (no commit info)

Re: [PATCH] fs: autofs: add MODULE_DESCRIPTION()

[Christian Brauner]

On Mon, 27 May 2024 12:22:16 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/autofs/autofs4.o
> 
> 

Applied to the v6.10-rc1 branch of the vfs/vfs.git tree.
Patches in the v6.10-rc1 branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: v6.10-rc1

[1/1] fs: autofs: add MODULE_DESCRIPTION()
      https://git.kernel.org/vfs/vfs/c/5478ce951be8

Re: [PATCH] fs: autofs: add MODULE_DESCRIPTION()

[Al Viro]

On Tue, May 28, 2024 at 01:39:03PM +0200, Christian Brauner wrote:
> On Mon, 27 May 2024 12:22:16 -0700, Jeff Johnson wrote:
> > Fix the 'make W=1' warning:
> > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/autofs/autofs4.o
> > 
> > 
> 
> Applied to the v6.10-rc1 branch of the vfs/vfs.git tree.
> Patches in the v6.10-rc1 branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
> 
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: v6.10-rc1

*Ugh*

Free advice: avoid mixing tag and branch names.  git tries to do the
right thing when it runs into ambiguities, but it's really asking for
headache.

Re: [PATCH] fs: autofs: add MODULE_DESCRIPTION()

[Ian Kent]

On 28/5/24 03:22, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/autofs/autofs4.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>   fs/autofs/init.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/autofs/init.c b/fs/autofs/init.c
> index b5e4dfa04ed0..1d644a35ffa0 100644
> --- a/fs/autofs/init.c
> +++ b/fs/autofs/init.c
> @@ -38,4 +38,5 @@ static void __exit exit_autofs_fs(void)
>   
>   module_init(init_autofs_fs)
>   module_exit(exit_autofs_fs)
> +MODULE_DESCRIPTION("Kernel automounter support");
>   MODULE_LICENSE("GPL");
>
> ---
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> change-id: 20240527-md-fs-autofs-62625640557b
>

Acked-by: Ian Kent <raven@themaw.net>


Ian

Re: [PATCH] fs: autofs: add MODULE_DESCRIPTION()

[Christian Brauner]

On Tue, May 28, 2024 at 07:03:46PM +0100, Al Viro wrote:
> On Tue, May 28, 2024 at 01:39:03PM +0200, Christian Brauner wrote:
> > On Mon, 27 May 2024 12:22:16 -0700, Jeff Johnson wrote:
> > > Fix the 'make W=1' warning:
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in fs/autofs/autofs4.o
> > > 
> > > 
> > 
> > Applied to the v6.10-rc1 branch of the vfs/vfs.git tree.
> > Patches in the v6.10-rc1 branch should appear in linux-next soon.
> > 
> > Please report any outstanding bugs that were missed during review in a
> > new review to the original patch series allowing us to drop it.
> > 
> > It's encouraged to provide Acked-bys and Reviewed-bys even though the
> > patch has now been applied. If possible patch trailers will be updated.
> > 
> > Note that commit hashes shown below are subject to change due to rebase,
> > trailer updates or similar. If in doubt, please check the listed branch.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> > branch: v6.10-rc1
> 
> *Ugh*

That was a bug in b4 which seems to have selected the wrong branch. The
is as I said elsewhere #vfs.module.description.