From: Eric Sandeen <sandeen@redhat.com>
To: Bill O'Donnell <bodonnel@redhat.com>, linux-fsdevel@vger.kernel.org
Cc: brauner@kernel.org
Subject: Re: [PATCH v3] efs: convert efs to use the new mount api
Date: Mon, 4 Mar 2024 13:04:37 -0600 [thread overview]
Message-ID: <7ca480f7-bea1-4ee8-aaf0-af8ad49f0e68@redhat.com> (raw)
In-Reply-To: <20240304161526.909415-1-bodonnel@redhat.com>
On 3/4/24 10:03 AM, Bill O'Donnell wrote:
> Convert the efs filesystem to use the new mount API.
>
> Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
This looks fine to me now.
Going forward, I might try to structure the changes so that
_reconfigure() stays in the same place as _remount_fs(), and
_get_tree stays in the same place as _mount(), when possible -
it makes the patch a little easier to review. But that's just a
minor suggestion.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
next prev parent reply other threads:[~2024-03-04 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:03 [PATCH v3] efs: convert efs to use the new mount api Bill O'Donnell
2024-03-04 19:04 ` Eric Sandeen [this message]
2024-03-05 11:15 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca480f7-bea1-4ee8-aaf0-af8ad49f0e68@redhat.com \
--to=sandeen@redhat.com \
--cc=bodonnel@redhat.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).