From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH 10/41] whiteout: Add vfs_whiteout() and whiteout inode operation Date: Tue, 27 Oct 2009 10:36:18 -0400 Message-ID: <7e0fb38c0910270736h13860a3ckf2690a76f99b35be@mail.gmail.com> References: <1256152779-10054-1-git-send-email-vaurora@redhat.com> <1256152779-10054-3-git-send-email-vaurora@redhat.com> <1256152779-10054-4-git-send-email-vaurora@redhat.com> <1256152779-10054-5-git-send-email-vaurora@redhat.com> <1256152779-10054-6-git-send-email-vaurora@redhat.com> <1256152779-10054-7-git-send-email-vaurora@redhat.com> <1256152779-10054-8-git-send-email-vaurora@redhat.com> <1256152779-10054-9-git-send-email-vaurora@redhat.com> <1256152779-10054-10-git-send-email-vaurora@redhat.com> <1256152779-10054-11-git-send-email-vaurora@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan Blunck , Alexander Viro , Christoph Hellwig , Andy Whitcroft , Scott James Remnant , Sandu Popa Marius , Jan Rekorajski , "J. R. Okajima" , Arnd Bergmann , Vladimir Dronnikov , Felix Fietkau , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Woodhouse To: Valerie Aurora Return-path: Received: from mail-pw0-f42.google.com ([209.85.160.42]:50123 "EHLO mail-pw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbZJ0OgP convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2009 10:36:15 -0400 In-Reply-To: <1256152779-10054-11-git-send-email-vaurora@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 21, 2009 at 3:19 PM, Valerie Aurora wr= ote: > From: Jan Blunck > > Simply white-out a given directory entry. This functionality is usual= ly used > in the sense of unlink. Therefore the given dentry can still be in-us= e and > contains an in-use inode. The filesystems inode operation has to do w= hat > unlink or rmdir would in that case. Since the dentry still might be i= n-use > we have to provide a fresh unhashed dentry that is used as the whiteo= ut > dentry instead. The given dentry is dropped and the whiteout dentry i= s > rehashed instead. > > Signed-off-by: Jan Blunck > Signed-off-by: David Woodhouse > Signed-off-by: Valerie Aurora > --- > =A0fs/dcache.c =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A04 +- > =A0fs/namei.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0104 ++++++++++++++++++++++= ++++++++++++++++++++++++++ > =A0include/linux/dcache.h | =A0 =A06 +++ > =A0include/linux/fs.h =A0 =A0 | =A0 =A03 + > =A04 files changed, 116 insertions(+), 1 deletions(-) > > diff --git a/include/linux/dcache.h b/include/linux/dcache.h > index 30b93b2..7648b49 100644 > --- a/include/linux/dcache.h > +++ b/include/linux/dcache.h > @@ -183,6 +183,7 @@ d_iput: =A0 =A0 =A0 =A0 =A0 =A0 no =A0 =A0 =A0 =A0= =A0 =A0 =A0no =A0 =A0 =A0 =A0 =A0 =A0 =A0no =A0 =A0 =A0 yes > =A0#define DCACHE_INOTIFY_PARENT_WATCHED =A00x0020 /* Parent inode is= watched by inotify */ > > =A0#define DCACHE_COOKIE =A0 =A0 =A0 =A0 =A00x0040 =A0/* For use by d= cookie subsystem */ > +#define DCACHE_WHITEOUT =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A00x0080 =A0/* = This negative dentry is a whiteout */ > > =A0#define DCACHE_FSNOTIFY_PARENT_WATCHED 0x0080 /* Parent inode is w= atched by some fsnotify listener */ > I don't think you want 2 flags with the 0x0080 value....... This can't be right. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html