From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] namei: Standardize callers of filename_create()
Date: Tue, 7 Sep 2021 13:35:12 -0700 [thread overview]
Message-ID: <7e6cfce8-7fad-a55f-c1b6-47db62da4344@oracle.com> (raw)
In-Reply-To: <YTfH6RW+3+5kVD+y@zeniv-ca.linux.org.uk>
On 9/7/21 1:13 PM, Al Viro wrote:
> On Wed, Sep 01, 2021 at 10:51:43AM -0700, Stephen Brennan wrote:
>> inline struct dentry *user_path_create(int dfd, const char __user *pathname,
>> struct path *path, unsigned int lookup_flags)
>> {
>> - return filename_create(dfd, getname(pathname), path, lookup_flags);
>> + struct filename *filename;
>> + struct dentry *dentry;
>> +
>> + filename = getname(pathname);
>> + dentry = filename_create(dfd, getname(pathname), path, lookup_flags);
>> + putname(filename);
>> + return dentry;
>
> Leaks, obviously...
>
Ouch, thanks for the catch. I'll send v2 shortly.
next prev parent reply other threads:[~2021-09-07 20:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 17:51 [PATCH 0/3] namei: fix use-after-free and adjust calling conventions Stephen Brennan
2021-09-01 17:51 ` [PATCH 1/3] namei: Fix use after free in kern_path_locked Stephen Brennan
2021-09-01 17:51 ` [PATCH 2/3] namei: Standardize callers of filename_lookup() Stephen Brennan
2021-09-01 17:51 ` [PATCH 3/3] namei: Standardize callers of filename_create() Stephen Brennan
2021-09-07 20:13 ` Al Viro
2021-09-07 20:35 ` Stephen Brennan [this message]
2021-09-07 21:09 ` [PATCH 0/3] namei: fix use-after-free and adjust calling conventions Al Viro
2021-09-07 21:43 ` Stephen Brennan
2021-09-07 21:54 ` Al Viro
2021-09-08 18:47 ` Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6cfce8-7fad-a55f-c1b6-47db62da4344@oracle.com \
--to=stephen.s.brennan@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).