From: Eric Sandeen <sandeen@redhat.com>
To: Christian Brauner <brauner@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: ignore auto and noauto options if given
Date: Mon, 3 Jun 2024 09:17:10 -0500 [thread overview]
Message-ID: <7e8f8a6c-0f8e-4237-9048-a504c8174363@redhat.com> (raw)
In-Reply-To: <20240603-holzschnitt-abwaschen-2f5261637ca8@brauner>
On 6/3/24 8:31 AM, Christian Brauner wrote:
> On Mon, Jun 03, 2024 at 09:24:50AM +0200, Wolfram Sang wrote:
>>
>>>>> Does that fix it for you?
>>>>
>>>> Yes, it does, thank you.
>>>>
>>>> Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>>> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>>
>>> Thanks, applied. Should be fixed by end of the week.
>>
>> It is in -next but not in rc2. rc3 then?
>
> Yes, it wasn't ready when I sent the fixes for -rc2 as I just put it in
> that day.
>
See my other reply, are you sure we should make this change? From a
"keep the old behavior" POV maybe so, but this looks to me like a
bug in busybox, passing fstab hint "options" like "auto" as actual mount
options being the root cause of the problem. debugfs isn't uniquely
affected by this behavior.
I'm not dead set against the change, just wanted to point this out.
Thanks,
-Eric
next prev parent reply other threads:[~2024-06-03 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 8:38 [PATCH] debugfs: ignore auto and noauto options if given Wolfram Sang
2024-05-24 13:55 ` Christian Brauner
2024-05-27 10:06 ` Wolfram Sang
2024-05-27 10:23 ` Geert Uytterhoeven
2024-05-27 12:19 ` Christian Brauner
2024-06-03 7:24 ` Wolfram Sang
2024-06-03 13:31 ` Christian Brauner
2024-06-03 14:17 ` Eric Sandeen [this message]
2024-06-03 14:33 ` Christian Brauner
2024-06-03 15:13 ` Eric Sandeen
2024-06-05 15:33 ` Christian Brauner
2024-06-03 19:52 ` Wolfram Sang
2024-05-29 20:43 ` Eric Sandeen
2024-05-29 22:05 ` Wolfram Sang
2024-05-29 22:33 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e8f8a6c-0f8e-4237-9048-a504c8174363@redhat.com \
--to=sandeen@redhat.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).