From: Jens Axboe <axboe@kernel.dk>
To: Joe Damato <jdamato@fastly.com>, linux-fsdevel@vger.kernel.org
Cc: netdev@vger.kernel.org, brauner@kernel.org,
asml.silence@gmail.com, hch@infradead.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"David S. Miller" <davem@davemloft.net>, Jan Kara <jack@suse.cz>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c
Date: Mon, 24 Mar 2025 16:14:06 -0600 [thread overview]
Message-ID: <80835395-d43d-46de-8ed6-2cc5c2268b19@kernel.dk> (raw)
In-Reply-To: <20250322203558.206411-1-jdamato@fastly.com>
On 3/22/25 2:35 PM, Joe Damato wrote:
> Greetings:
>
> While reading through the splice and socket code I noticed that some
> splice helpers (like sock_splice_read and sock_splice_eof) live in
> net/socket.c, but splice_to_socket does not.
>
> I am not sure if there is a reason for this, but it seems like moving
> this code provides some advantages:
> - Eliminates the #ifdef CONFIG_NET from fs/splice.c
> - Keeps the socket related splice helpers together in net/socket.c
> where it seems (IMHO) more logical for them to live
Not sure I think this is a good idea. Always nice to get rid of some
ifdefs, but the code really should be where it's mostly related to, and
the socket splice helpers have very little to do with the networking
code, it's mostly just pure splice code.
--
Jens Axboe
next prev parent reply other threads:[~2025-03-24 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 20:35 [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c Joe Damato
2025-03-22 20:35 ` [PATCH vfs/for-next 1/3] pipe: Move pipe wakeup helpers out of splice Joe Damato
2025-03-24 22:15 ` Jens Axboe
2025-03-22 20:35 ` [PATCH vfs/for-next 2/3] splice: Move splice_to_socket to net/socket.c Joe Damato
2025-03-24 21:15 ` Jakub Kicinski
2025-03-24 22:53 ` Joe Damato
2025-03-25 14:40 ` Christian Brauner
2025-03-22 20:35 ` [PATCH vfs/for-next 3/3] net: splice_to_socket: RCT declaration cleanup Joe Damato
2025-03-24 22:14 ` Jens Axboe [this message]
2025-03-24 22:51 ` [PATCH vfs/for-next 0/3] Move splice_to_socket to net/socket.c Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80835395-d43d-46de-8ed6-2cc5c2268b19@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=horms@kernel.org \
--cc=jack@suse.cz \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).