linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] VFS: Fix seven errors in bitmap.c
       [not found] <tencent_CE461BFFDACFEA943A778650FB672D9E3207@qq.com>
@ 2023-07-14  7:14 ` huzhi001
  2023-07-14 10:46   ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: huzhi001 @ 2023-07-14  7:14 UTC (permalink / raw)
  To: dsterba; +Cc: linux-fsdevel, linux-kernel

The following checkpatch errors are removed:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: ZhiHu <huzhi001@208suo.com>
---
  fs/affs/bitmap.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/affs/bitmap.c b/fs/affs/bitmap.c
index 5ba9ef2742f6..b1620b6ff8a9 100644
--- a/fs/affs/bitmap.c
+++ b/fs/affs/bitmap.c
@@ -87,19 +87,19 @@ affs_free_block(struct super_block *sb, u32 block)
      return;

  err_free:
-    affs_warning(sb,"affs_free_block","Trying to free block %u which is 
already free", block);
+    affs_warning(sb, "affs_free_block", "Trying to free block %u which 
is already free", block);
      mutex_unlock(&sbi->s_bmlock);
      return;

  err_bh_read:
-    affs_error(sb,"affs_free_block","Cannot read bitmap block %u", 
bm->bm_key);
+    affs_error(sb, "affs_free_block", "Cannot read bitmap block %u", 
bm->bm_key);
      sbi->s_bmap_bh = NULL;
      sbi->s_last_bmap = ~0;
      mutex_unlock(&sbi->s_bmlock);
      return;

  err_range:
-    affs_error(sb, "affs_free_block","Block %u outside partition", 
block);
+    affs_error(sb, "affs_free_block", "Block %u outside partition", 
block);
  }

  /*
@@ -232,7 +232,7 @@ affs_alloc_block(struct inode *inode, u32 goal)
      return blk;

  err_bh_read:
-    affs_error(sb,"affs_read_block","Cannot read bitmap block %u", 
bm->bm_key);
+    affs_error(sb, "affs_read_block", "Cannot read bitmap block %u", 
bm->bm_key);
      sbi->s_bmap_bh = NULL;
      sbi->s_last_bmap = ~0;
  err_full:

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] VFS: Fix seven errors in bitmap.c
  2023-07-14  7:14 ` [PATCH] VFS: Fix seven errors in bitmap.c huzhi001
@ 2023-07-14 10:46   ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2023-07-14 10:46 UTC (permalink / raw)
  To: huzhi001; +Cc: dsterba, linux-fsdevel, linux-kernel

On Fri, Jul 14, 2023 at 03:14:18PM +0800, huzhi001@208suo.com wrote:
> The following checkpatch errors are removed:
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ',' (ctx:VxV)

The AFFS module gets only bug fixes (as can be seen in the MAINTAINERS
file) or API updates, not coding style fixes.

The sources have way more stylistic things that checkpatch does not like
but we are not going to fix them:

total: 0 errors, 1 warnings, 189 lines checked
total: 1 errors, 5 warnings, 543 lines checked
total: 7 errors, 4 warnings, 365 lines checked
total: 1 errors, 1 warnings, 144 lines checked
total: 2 errors, 13 warnings, 1009 lines checked
total: 8 errors, 12 warnings, 422 lines checked
total: 0 errors, 2 warnings, 584 lines checked
total: 15 errors, 13 warnings, 681 lines checked
total: 1 errors, 2 warnings, 77 lines checked
total: 4 errors, 10 warnings, 328 lines checked
total: 4 errors, 0 warnings, 148 lines checked

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-14 10:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <tencent_CE461BFFDACFEA943A778650FB672D9E3207@qq.com>
2023-07-14  7:14 ` [PATCH] VFS: Fix seven errors in bitmap.c huzhi001
2023-07-14 10:46   ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).