Re: [PATCH] mm: remove wb_writeout_inc

[Anshuman Khandual <anshuman.khandual@arm.com>]

On 10/07/26 10:40 AM, Christoph Hellwig wrote:
> Remove this entirely unused but exported function.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> ---
>  include/linux/backing-dev.h |  2 --
>  mm/page-writeback.c         | 10 ----------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 5b7d12b40d5e..c2284466e7aa 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -76,8 +76,6 @@ static inline s64 wb_stat_sum(struct bdi_writeback *wb, enum wb_stat_item item)
>  	return percpu_counter_sum_positive(&wb->stat[item]);
>  }
>  
> -extern void wb_writeout_inc(struct bdi_writeback *wb);
> -
>  /*
>   * maximal error of a stat counter.
>   */
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index e98748112d1e..47495be68598 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -584,16 +584,6 @@ static inline void __wb_writeout_add(struct bdi_writeback *wb, long nr)
>  				       wb->bdi->max_prop_frac, nr);
>  }
>  
> -void wb_writeout_inc(struct bdi_writeback *wb)
> -{
> -	unsigned long flags;
> -
> -	local_irq_save(flags);
> -	__wb_writeout_add(wb, 1);
> -	local_irq_restore(flags);
> -}
> -EXPORT_SYMBOL_GPL(wb_writeout_inc);
> -
>  /*
>   * On idle system, we can be called long after we scheduled because we use
>   * deferred timers so count with missed periods.