From: David Laight <David.Laight@ACULAB.COM>
To: 'Al Viro' <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read_write.c
Date: Mon, 28 Aug 2023 14:25:22 +0000 [thread overview]
Message-ID: <81ccf8f3d7294cffab754901df83b401@AcuMS.aculab.com> (raw)
In-Reply-To: <20230828140934.GY3390869@ZenIV>
From: Al Viro
> Sent: 28 August 2023 15:10
>
> On Mon, Aug 28, 2023 at 02:30:42PM +0200, Christian Brauner wrote:
> > On Mon, Aug 28, 2023 at 05:00:36AM -0700, Christoph Hellwig wrote:
> > > On Mon, Aug 28, 2023 at 11:50:56PM +0800, Kemeng Shi wrote:
> > > > use helpers for calling f_op->{read,write}_iter() in read_write.c
> > > >
> > >
> > > Why? We really should just remove the completely pointless wrappers
> > > instead.
> >
> > Especially because it means you chase this helper to figure out what's
> > actually going on. If there was more to it then it would make sense but
> > not just as a pointless wrapper.
>
> It's borderline easier to grep for, but not dramatically so. call_mmap()
> has a stronger argument in favour - there are several methods called
> ->mmap and telling one from another is hard without looking into context.
Which might be a justification for renaming some/all of the ->mmap()
do make them easier to find.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2023-08-28 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:50 [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read_write.c Kemeng Shi
2023-08-28 12:00 ` Christoph Hellwig
2023-08-28 12:17 ` Kemeng Shi
2023-08-28 12:43 ` Matthew Wilcox
2023-08-28 12:19 ` Matthew Wilcox
2023-08-28 12:30 ` Christian Brauner
2023-08-28 14:09 ` Al Viro
2023-08-28 14:25 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81ccf8f3d7294cffab754901df83b401@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=brauner@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).