From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F253EC7619D for ; Mon, 17 Feb 2020 01:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D595A20718 for ; Mon, 17 Feb 2020 01:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgBQBlb (ORCPT ); Sun, 16 Feb 2020 20:41:31 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:34758 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726723AbgBQBlb (ORCPT ); Sun, 16 Feb 2020 20:41:31 -0500 Received: from mr3.cc.vt.edu (mr3.cc.ipv6.vt.edu [IPv6:2607:b400:92:8500:0:7f:b804:6b0a]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id 01H1fUpU026546 for ; Sun, 16 Feb 2020 20:41:30 -0500 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mr3.cc.vt.edu (8.14.7/8.14.7) with ESMTP id 01H1fOe5016079 for ; Sun, 16 Feb 2020 20:41:29 -0500 Received: by mail-qk1-f199.google.com with SMTP id t186so10932957qkf.9 for ; Sun, 16 Feb 2020 17:41:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=sv2ceZp1op4PModOTmniGKJ7V5g03pJcc68F5eGW640=; b=Nj6UiXDywEa+I8++R3VmQNL8bwzW+JLBq0iOrBaT3M8pGnFuMhXFSYdqf2idMx4779 jbKJrlDVtedVE/McN33z0lxi6YP3zxiK35ovlgP38K9FYRLe/Yuhbv51NLmLagfSpLz5 WZOaz/otA6zNFEArkjyUy++2KPQAHMa5MwQ3KbDt6rhxYXWxYAt9MHHVnMZoCFCJ7SFr WRvVdQV312jQZ9hx/1kGdy/cLIdmSpZUruCZPY5k3wou5cowZKJQUA2EehY20I1RQblI 3EP5bMhiMVfteX6/ASQvMH+CkI8cz0owUSwNCuO9Y6i9VrThgsngyg5PPaXfKD0GbUfp 1NFw== X-Gm-Message-State: APjAAAXfTNLrOmQ6b6/zFNeQKKyXKvALCMI5CjV7l73QBeN9KHBMEcDV iX2R3nRey0qJ3dJj9o2vl5B6rolAa8+yOGWEJ4hpnmaQQj+eGxtgK3SPSjAwPwJxEiR8azgNoKr w+4NNhAr7EmoGjveUC4GHQ7HWxDSs8XFVSVCE X-Received: by 2002:a37:a5cc:: with SMTP id o195mr12277342qke.25.1581903684497; Sun, 16 Feb 2020 17:41:24 -0800 (PST) X-Google-Smtp-Source: APXvYqz7bWoxPayu8kgU2Bhg/GlzNU2d7s9SpWB7AsfKmq7sORME7CHUPB+YiVTvKi5yRIFYIJPPrA== X-Received: by 2002:a37:a5cc:: with SMTP id o195mr12277322qke.25.1581903684177; Sun, 16 Feb 2020 17:41:24 -0800 (PST) Received: from turing-police ([2601:5c0:c001:c9e1::359]) by smtp.gmail.com with ESMTPSA id o19sm7721193qkh.135.2020.02.16.17.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2020 17:41:22 -0800 (PST) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: "Namjae Jeon" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de, sj1557.seo@samsung.com, pali.rohar@gmail.com, arnd@arndb.de, viro@zeniv.linux.org.uk, "'Namjae Jeon'" , "'Sasha Levin'" Subject: Re: [PATCH] exfat: tighten down num_fats check In-Reply-To: <001b01d5e52a$7f029340$7d07b9c0$@samsung.com> References: <89603.1581722921@turing-police> <001b01d5e52a$7f029340$7d07b9c0$@samsung.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1581903681_14173P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sun, 16 Feb 2020 20:41:21 -0500 Message-ID: <83075.1581903681@turing-police> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org --==_Exmh_1581903681_14173P Content-Type: text/plain; charset=us-ascii On Mon, 17 Feb 2020 09:37:55 +0900, "Namjae Jeon" said: > Could you please update error message for the reason why num_fats is allowed > only 1? Sure.. No problem.. > > ret = -EINVAL; > > goto free_bh; > Let's remove exfat_mirror_bh(), FAT2_start_sector variable and the below > related codes together. > > sbi->FAT2_start_sector = p_bpb->bsx.num_fats == 1 ? > sbi->FAT1_start_sector : > sbi->FAT1_start_sector + sbi->num_FAT_sectors; You might want to hold off on that part for a bit - I've asked Sasha Levin for input on what exactly Windows does with this, and Pali has a not-obviously-wrong suggestion on using the second FAT table. The code tracking FAT2_start_sector looks OK - what would be missing is doing a similar versioning on the FAT the rest of the code references. We may end up heaving that code over the side in the end, but let's make sure we're doing it with more information in hand.... --==_Exmh_1581903681_14173P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBXknvQAdmEQWDXROgAQLx9hAArGcsQ4heaHoCkYlLQykrtoFHMf3RgBv1 1SxDyx4wEynQMiX7+x3wmRD7Gq4QGEfQSmBBMwEDaPNtbSpFnFwIyJapareTl1zU +r+ulf5h2/6Kbeglly89Kn+6HcH0aZ5QktqtLkgohr7x4MfZ16Tr6qCQP9w8Aovt 16hob7ql94iygjTppeE6F99tTQBY7oRHTJGuwB17RsoOrSM6XXuAb/8HKhTOjXW8 RsyxYBw4R8RNlu/qjmYqs9kk3tXJX3Vc1lG2JVMZQnSIe/Yp1nx4c79OPGPuhGqG iKLmgOz8jiG74hOCykFctZDfoNX0CJpvRfmBRz4WkYcu1MwFxW/7LN7PJROM5Ixr JQG32p0lzDqm7fxvUzvE+5sw+E5M5ioigPfSTfOI683QJ/kUaUOy9de/90Um8g3v lyYKu3MdWOq5Zqtz/aBT7/BTI0FK0QjMbu+jYSXm8oDoTx6adeJEytGFpG/D2asA B95CfG3Rh14EPxCWfXp9i+7nQ/mtHlN7qtEPHumxaHFgJXK3Irvj5P5qLRw6mQG2 PH1bLCUrbX1SF8mroSho364cdQ8J/j3vLwE2HltcXaLk+cPuKkaZbbYB3iwWYkB9 zws0G+WKsVXBPVOoeFkWfaHCGFT/7xvAY2zNM1MbPLQXG5KrZa+DIlnYRCFfbUVG Snmb2rUl6oY= =SS6+ -----END PGP SIGNATURE----- --==_Exmh_1581903681_14173P--