From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] [Request for inclusion] Filesystem in Userspace Date: Tue, 16 Nov 2004 12:35:57 +0200 Message-ID: <84144f020411160235616c529b@mail.gmail.com> References: <84144f0204111602136a9bbded@mail.gmail.com> Reply-To: Pekka Enberg Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from wproxy.gmail.com ([64.233.184.197]:18255 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261949AbUKPKf5 (ORCPT ); Tue, 16 Nov 2004 05:35:57 -0500 Received: by wproxy.gmail.com with SMTP id 63so574405wri for ; Tue, 16 Nov 2004 02:35:57 -0800 (PST) To: Miklos Szeredi In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, On Tue, 16 Nov 2004 11:20:22 +0100, Miklos Szeredi wrote: > > - Breaks if CONFIG_PROC_FS is not enabled. > > Yes. Would a device node be better? Perhaps. This way there's no > need to allocate a major/minor for a device. ...or fix your Kconfig to select procfs. :) On Tue, 16 Nov 2004 11:20:22 +0100, Miklos Szeredi wrote: > > - Explicit casts are not needed when converting void pointers > > (found in various places). > > But they don't hurt either. At least I can be sure to assign the > right kind of pointer. Hmm? The conversion is guaranteed by the standard which makes them redundant. And redundancy does hurt maintainability. The have been patches to get rid of the existing casts so please don't introduce new ones. Pekka