From: Pekka Enberg <penberg@gmail.com>
To: "ericvh@gmail.com" <ericvh@gmail.com>
Cc: linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
viro@parcelfarce.linux.theplanet.co.uk,
linux-fsdevel@vger.kernel.org, penberg@cs.helsinki.fi
Subject: Re: [RFC][patch 2/7] v9fs: VFS file and directory operations (2.0-rc6)
Date: Tue, 24 May 2005 10:14:12 +0300 [thread overview]
Message-ID: <84144f0205052400143e97796e@mail.gmail.com> (raw)
In-Reply-To: <200505232225.j4NMPXe1029024@ms-smtp-02-eri0.texas.rr.com>
Hi,
On 5/24/05, ericvh@gmail.com <ericvh@gmail.com> wrote:
> +static ssize_t
> +v9fs_file_write(struct file *filp, const char __user * data,
> + size_t count, loff_t * offset)
> +{
> + int ret = -1;
> + char *buffer;
> +
> + buffer = kmalloc(count, GFP_KERNEL);
> + if (buffer == NULL) {
> + BUG();
I think simply returning -ENOMEM is sufficient. BUG seems way too
aggressive. (Found this in other places as well.)
> + return -ENOMEM;
> + }
Pekka
prev parent reply other threads:[~2005-05-24 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 22:25 [RFC][patch 2/7] v9fs: VFS file and directory operations (2.0-rc6) ericvh
2005-05-24 7:14 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f0205052400143e97796e@mail.gmail.com \
--to=penberg@gmail.com \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).