From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: GFS, what's remaining Date: Mon, 5 Sep 2005 09:32:59 +0300 Message-ID: <84144f02050904233274d45230@mail.gmail.com> References: <20050901104620.GA22482@redhat.com> <1125574523.5025.10.camel@laptopd505.fenrus.org> <20050905054348.GC11337@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Arjan van de Ven , linux-fsdevel@vger.kernel.org, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-cluster@redhat.com Return-path: Received: from nproxy.gmail.com ([64.233.182.202]:4124 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S932254AbVIEGdA convert rfc822-to-8bit (ORCPT ); Mon, 5 Sep 2005 02:33:00 -0400 Received: by nproxy.gmail.com with SMTP id x37so306650nfc for ; Sun, 04 Sep 2005 23:32:59 -0700 (PDT) To: David Teigland In-Reply-To: <20050905054348.GC11337@redhat.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > > +void gfs2_glock_hold(struct gfs2_glock *gl) > > +{ > > + glock_hold(gl); > > +} > > > > eh why? On 9/5/05, David Teigland wrote: > You removed the comment stating exactly why, see below. If that's not a > accepted technique in the kernel, say so and I'll be happy to change it > here and elsewhere. Is there a reason why users of gfs2_glock_hold() cannot use glock_hold() directly? Pekka