From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 6/12: eCryptfs] Superblock operations Date: Sat, 19 Nov 2005 12:50:13 +0200 Message-ID: <84144f020511190250x2efdbfb4vf33245b3f7216fe5@mail.gmail.com> References: <20051119041130.GA15559@sshock.rn.byu.edu> <20051119041910.GF15747@sshock.rn.byu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from nproxy.gmail.com ([64.233.182.200]:58021 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S1751141AbVKSKuP convert rfc822-to-8bit (ORCPT ); Sat, 19 Nov 2005 05:50:15 -0500 Received: by nproxy.gmail.com with SMTP id n28so19038nfc for ; Sat, 19 Nov 2005 02:50:13 -0800 (PST) To: Phillip Hellewell In-Reply-To: <20051119041910.GF15747@sshock.rn.byu.edu> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/19/05, Phillip Hellewell wrote: > +/** > + * This is called through iput_final(). > + * This is function will replace generic_drop_inode. The end result of which > + * is we are skipping the check in inode->i_nlink, which we do not use. > + */ > +static void ecryptfs_drop_inode(struct inode *inode) { > + generic_delete_inode(inode); > +} Please drop this useless wrapper and introduce it when it actually does something. Pekka