From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 7/12: eCryptfs] File operations Date: Sat, 19 Nov 2005 12:53:03 +0200 Message-ID: <84144f020511190253p5f689346u8729bce45bd7df5@mail.gmail.com> References: <20051119041130.GA15559@sshock.rn.byu.edu> <20051119042029.GG15747@sshock.rn.byu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from nproxy.gmail.com ([64.233.182.193]:42609 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S1751173AbVKSKxF convert rfc822-to-8bit (ORCPT ); Sat, 19 Nov 2005 05:53:05 -0500 Received: by nproxy.gmail.com with SMTP id x4so21124nfb for ; Sat, 19 Nov 2005 02:53:03 -0800 (PST) To: Phillip Hellewell In-Reply-To: <20051119042029.GG15747@sshock.rn.byu.edu> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/19/05, Phillip Hellewell wrote: > +/** > + * Opens the file specified by inode. > + * > + * @param inode inode speciying file to open > + * @param file Structure to return filled in > + * @return Zero on success; non-zero otherwise > + */ General comment: please use the kerneldoc format properly or don't use kerneldoc at all. Pekka