From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 6/13: eCryptfs] Superblock operations
Date: Thu, 4 May 2006 17:26:43 +0300
Message-ID: <84144f020605040726p2279aabag325c6c74cbb16ea6@mail.gmail.com>
References: <20060504031755.GA28257@hellewell.homeip.net>
	 <20060504033829.GE28613@hellewell.homeip.net>
	 <20060504095552.GC5844@ucw.cz>
	 <afcef88a0605040702q199a2be2tdd8a291eacf7035@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
	format=flowed
Content-Transfer-Encoding: 7BIT
Cc: "Pavel Machek" <pavel@suse.cz>,
	"Phillip Hellewell" <phillip@hellewell.homeip.net>,
	"Andrew Morton" <akpm@osdl.org>, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk,
	mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com,
	toml@us.ibm.com, yoder1@us.ibm.com,
	"James Morris" <jmorris@namei.org>,
	"Stephen C. Tweedie" <sct@redhat.com>,
	"Erez Zadok" <ezk@cs.sunysb.edu>,
	"David Howells" <dhowells@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from wr-out-0506.google.com ([64.233.184.234]:46660 "EHLO
	wr-out-0506.google.com") by vger.kernel.org with ESMTP
	id S1751472AbWEDO0o convert rfc822-to-8bit (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 4 May 2006 10:26:44 -0400
Received: by wr-out-0506.google.com with SMTP id i12so369527wra
        for <linux-fsdevel@vger.kernel.org>; Thu, 04 May 2006 07:26:43 -0700 (PDT)
To: "Michael Thompson" <michael.craig.thompson@gmail.com>
In-Reply-To: <afcef88a0605040702q199a2be2tdd8a291eacf7035@mail.gmail.com>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> On 5/4/06, Pavel Machek <pavel@suse.cz> wrote:
> > > +static int ecryptfs_statfs(struct super_block *sb, struct kstatfs *buf)
> > > +{
> > > +     int rc = 0;
> > > +
> > > +     ecryptfs_printk(KERN_DEBUG, "Enter\n");
> > > +     rc = vfs_statfs(ECRYPTFS_SUPERBLOCK_TO_LOWER(sb), buf);
> > > +     ecryptfs_printk(KERN_DEBUG, "Exit; rc = [%d]\n", rc);
> > > +     return rc;
> > > +}
> >
> > This is ugly. Could you remove the debugging, or at least use dprintk?

On 5/4/06, Michael Thompson <michael.craig.thompson@gmail.com> wrote:
> How would dprintk differ from the current approach with ecryptfs_printk?

Not much, so please just kill the function tracing stuffs. Thanks.

                                           Pekka