From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Phillip Hellewell" <phillip@hellewell.homeip.net>
Cc: "Andrew Morton" <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com,
mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com,
"James Morris" <jmorris@namei.org>,
"Stephen C. Tweedie" <sct@redhat.com>,
"Erez Zadok" <ezk@cs.sunysb.edu>,
"David Howells" <dhowells@redhat.com>
Subject: Re: [PATCH 10/13: eCryptfs] Mmap operations
Date: Wed, 28 Jun 2006 17:16:34 +0300 [thread overview]
Message-ID: <84144f020606280716y2bea236du2ea84018e15a7d0a@mail.gmail.com> (raw)
In-Reply-To: <20060513034708.GJ18631@hellewell.homeip.net>
Hi,
Sorry for the late comment...
On 5/13/06, Phillip Hellewell <phillip@hellewell.homeip.net> wrote:
> +static struct page *ecryptfs_get1page(struct file *file, int index)
> +{
> + struct page *page;
> + struct dentry *dentry;
> + struct inode *inode;
> + struct address_space *mapping;
> +
> + dentry = file->f_dentry;
> + inode = dentry->d_inode;
> + mapping = inode->i_mapping;
> + page = read_cache_page(mapping, index,
> + (filler_t *)mapping->a_ops->readpage,
> + (void *)file);
> + if (IS_ERR(page))
> + goto out;
> + wait_on_page_locked(page);
Why no check for PageUptodate?
> +out:
> + return page;
> +}
next prev parent reply other threads:[~2006-06-28 14:16 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-13 3:37 [PATCH 0/13: eCryptfs] eCryptfs Patch Set Phillip Hellewell
2006-05-13 3:40 ` [PATCH 1/13: eCryptfs] fs/Makefile and fs/Kconfig Phillip Hellewell
2006-05-13 8:51 ` Jan-Benedict Glaw
2006-05-13 3:41 ` [PATCH 2/13: eCryptfs] Documentation Phillip Hellewell
2006-05-13 3:42 ` [PATCH 3/13: eCryptfs] Makefile Phillip Hellewell
2006-05-13 3:42 ` [PATCH 4/13: eCryptfs] Main module functions Phillip Hellewell
2006-05-13 3:43 ` [PATCH 5/13: eCryptfs] Header declarations Phillip Hellewell
2006-05-13 3:44 ` [PATCH 6/13: eCryptfs] Superblock operations Phillip Hellewell
2006-05-13 3:45 ` [PATCH 7/13: eCryptfs] Dentry operations Phillip Hellewell
2006-05-13 3:45 ` [PATCH 8/13: eCryptfs] File operations Phillip Hellewell
2006-05-13 3:46 ` [PATCH 9/13: eCryptfs] Inode operations Phillip Hellewell
2006-05-13 3:47 ` [PATCH 10/13: eCryptfs] Mmap operations Phillip Hellewell
2006-06-28 14:16 ` Pekka Enberg [this message]
2006-06-28 15:02 ` Michael Halcrow
2006-05-13 3:47 ` [PATCH 11/13: eCryptfs] Keystore Phillip Hellewell
2006-05-13 3:48 ` [PATCH 12/13: eCryptfs] Crypto functions Phillip Hellewell
2006-05-13 3:49 ` [PATCH 13/13: eCryptfs] Debug functions Phillip Hellewell
2006-05-13 4:21 ` [PATCH 0/13: eCryptfs] eCryptfs Patch Set Nick Piggin
2006-05-13 16:21 ` Michael Thompson
2006-05-14 2:59 ` Nick Piggin
2006-05-14 3:13 ` Andrew Morton
2006-05-14 3:26 ` Nick Piggin
2006-05-14 3:43 ` Michael Halcrow
2006-05-14 3:54 ` Greg KH
2006-05-15 10:17 ` David Howells
2006-05-15 10:59 ` Andrew Morton
2006-05-20 9:57 ` Christoph Hellwig
2006-06-01 20:47 ` Michael Halcrow
2006-07-07 10:01 ` Christoph Hellwig
2006-07-07 11:54 ` Christoph Hellwig
2006-07-07 12:23 ` Pekka Enberg
2006-07-07 17:22 ` David Quigley
2006-07-08 17:21 ` Christoph Hellwig
2006-07-08 21:22 ` Erez Zadok
-- strict thread matches above, loose matches on Subject: below --
2006-05-04 3:17 [PATCH 0/12: eCryptfs] eCryptfs version 0.1.6 Phillip Hellewell
2006-05-04 3:41 ` [PATCH 10/13: eCryptfs] Mmap operations Phillip Hellewell
2006-05-04 15:13 ` Pekka Enberg
2006-05-04 21:43 ` David Howells
2006-05-05 15:22 ` Dave Kleikamp
2006-05-05 15:38 ` Pekka Enberg
2006-05-06 2:21 ` Andrew Morton
2006-05-06 16:00 ` Michael Halcrow
2006-05-06 16:42 ` Andrew Morton
2006-05-06 16:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020606280716y2bea236du2ea84018e15a7d0a@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=ezk@cs.sunysb.edu \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcthomps@us.ibm.com \
--cc=mhalcrow@us.ibm.com \
--cc=mike@halcrow.us \
--cc=phillip@hellewell.homeip.net \
--cc=sct@redhat.com \
--cc=toml@us.ibm.com \
--cc=viro@ftp.linux.org.uk \
--cc=yoder1@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).