From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pekka Enberg" Subject: Re: [PATCH 1/2] LogFS proper Date: Tue, 8 May 2007 22:15:18 +0300 Message-ID: <84144f020705081215t73f2c0fq8ecb677423329cd8@mail.gmail.com> References: <20070507215913.GA15054@lazybastard.org> <20070507220036.GB15054@lazybastard.org> <1178608950.3042.273.camel@localhost.localdomain> <20070508163226.GA22443@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Thomas Gleixner" , "Andrew Morton" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Dave Kleikamp" , "David Chinner" To: "=?ISO-8859-1?Q?J=F6rn_Engel?=" Return-path: In-Reply-To: <20070508163226.GA22443@lazybastard.org> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 5/8/07, J=F6rn Engel wrote: > > > +typedef __be16 be16; > > > +typedef __be32 be32; > > > +typedef __be64 be64; > > > > Why are those typedefs necessary ? > > Not strictly. I tend to use the be* types fairly often in the code a= nd > simply grew weary of seeing the underscores. > > Any objections if I seperate out the userspace headers and keep the > shorthands for kernel code only? Not sure what you mean but I would prefer you drop the typedefs complet= ely.