From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pekka Enberg" Subject: Re: [PATCH] LogFS take three Date: Wed, 16 May 2007 15:36:44 +0300 Message-ID: <84144f020705160536i189f6206sffc964a145177da7@mail.gmail.com> References: <20070515151919.GA32510@lazybastard.org> <20070516122603.GE5472@lazybastard.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, "Albert Cahalan" , "Thomas Gleixner" , "Jan Engelhardt" , "Evgeniy Polyakov" , "Greg KH" , "Ingo Oeser" To: "=?ISO-8859-1?Q?J=F6rn_Engel?=" Return-path: Received: from nz-out-0506.google.com ([64.233.162.231]:36594 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757241AbXEPMgp convert rfc822-to-8bit (ORCPT ); Wed, 16 May 2007 08:36:45 -0400 Received: by nz-out-0506.google.com with SMTP id r28so534387nza for ; Wed, 16 May 2007 05:36:45 -0700 (PDT) In-Reply-To: <20070516122603.GE5472@lazybastard.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 5/16/07, J=F6rn Engel wrote: > > > +/* FIXME: all this mess should get replaced by using the page ca= che */ > > > +static void fixup_from_wbuf(struct super_block *sb, struct logfs= _area > > *area, > > > + void *read, u64 ofs, size_t readlen) > > > +{ > > > > Indeed. And I think you're getting some more trouble because of thi= s... > > More trouble? =46orgot to add (see below). Seems logfs_segment_read would be simpler too if you fixed this. > [ Objects are the units that get compressed. Segments can contain bo= th > compressed and uncompressed objects. ] > > It is a trade-off. Each object has a 24 Byte header plus X Bytes of > data. Whether the data is compressed or not is indicated in the head= er. Was my point really. Why do segments contain both compressed and uncompressed objects? - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html