From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Kalpak Shah" <kalpak@clusterfs.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.
Date: Fri, 13 Jul 2007 15:22:29 +0300 [thread overview]
Message-ID: <84144f020707130522l3a800b61i6b7c4d9084277cdf@mail.gmail.com> (raw)
In-Reply-To: <1184322648.4315.2.camel@garfield.linsyssoft.com>
On 7/13/07, Kalpak Shah <kalpak@clusterfs.com> wrote:
> > EXT4_DIR_LINK_MAX() is buggy: it evaluates its arg twice.
>
> #define EXT4_DIR_LINK_MAX(dir) (!is_dx(dir) && (dir)->i_nlink >= EXT4_LINK_MAX)
[snip]
> Sorry, I didn't understand what is the problem with this macro?
The expression represented by 'dir' is evaluated twice (think dir++
here). It's safer to make it a static inline function.
Pekka
next prev parent reply other threads:[~2007-07-13 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 7:38 [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit Mingming Cao
2007-07-11 5:40 ` Andrew Morton
2007-07-11 12:45 ` Andreas Dilger
2007-07-13 10:30 ` Kalpak Shah
2007-07-13 12:22 ` Pekka Enberg [this message]
2007-07-13 16:53 ` Andrew Morton
2007-07-17 9:49 ` Kalpak Shah
2007-07-22 22:52 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020707130522l3a800b61i6b7c4d9084277cdf@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=kalpak@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).