From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pekka Enberg" Subject: Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland Date: Mon, 8 Oct 2007 14:18:39 +0300 Message-ID: <84144f020710080418r37639efcx495bdb199f7540c2@mail.gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Erez Zadok" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Colin Watson" To: "Ryan Finnie" Return-path: Received: from rv-out-0910.google.com ([209.85.198.185]:49733 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbXJHLSk (ORCPT ); Mon, 8 Oct 2007 07:18:40 -0400 Received: by rv-out-0910.google.com with SMTP id k20so729052rvb for ; Mon, 08 Oct 2007 04:18:40 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi Ryan, On 10/8/07, Ryan Finnie wrote: > Doesn't appear to be enough. I can't figure out why (since it appears > write_cache_pages bubbles up directly to sys_msync), but with that > patch applied, in my test case[1], msync returns -1 EIO. However, > with the exact same kernel without that patch applied, msync returns > 524288 (AOP_WRITEPAGE_ACTIVATE). But as your patch specifically flips > 524288 to 0, I can't figure out how it eventually returns -1 EIO. > > [1] "apt-get check" on a unionfs2 mount backed by tmpfs over cdrom, > standard livecd setup You have swap device disabled, right? If so, I can't see any reason why msync(2) on tmpfs would return -EIO. Can you please send a strace log for your test case? Pekka