From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pekka Enberg" Subject: Re: [PATCH+comment] fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE Date: Thu, 25 Oct 2007 10:24:22 +0300 Message-ID: <84144f020710250024q683cfff2ubd1f8bda75415e2c@mail.gmail.com> References: <200710142232.l9EMW8kK029572@agora.fsl.cs.sunysb.edu> <84144f020710150447o94b1babo8b6e6a647828465f@mail.gmail.com> <20071024140836.a0098180.akpm@linux-foundation.org> <84144f020710242237q3aa8e96dtc8cf3f02f2af2cc9@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Andrew Morton" , ezk@cs.sunysb.edu, ryan@finnie.org, mhalcrow@us.ibm.com, cjwatson@ubuntu.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org To: "Hugh Dickins" Return-path: Received: from rv-out-0910.google.com ([209.85.198.191]:34684 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755658AbXJYHYW (ORCPT ); Thu, 25 Oct 2007 03:24:22 -0400 Received: by rv-out-0910.google.com with SMTP id k20so400011rvb for ; Thu, 25 Oct 2007 00:24:22 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi Hugh, On 10/25/07, Hugh Dickins wrote: > With unionfs also fixed, we don't know of an absolute need for this > patch (and so, on that basis, the !wbc->for_reclaim case could indeed > be removed very soon); but as I see it, the unionfs case has shown > that it's time to future-proof this code against whatever stacking > filesystems come along. Heh, what can I say, after several readings, I still find your above explanation (which I totally agree with) more to the point than the actual comment :-). In any case, the patch looks good to me. Reviewed-by: Pekka Enberg Pekka